Misc cgroup fixes - #498
Merged
Merged
Conversation
The kernel delegation docs require write access on the directory so the delegatee can mkdir() children. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
A cgroup holding processes cannot enable controllers for its children, so init/ had to stay a leaf. The hotplug helpers 10-hotplug.conf.in places there ended up in groups where cpu.weight and friends could never be set. Keeping PID 1 in the root cgroup makes init/ a domain like the others. It also unbreaks lxc-based runtimes: liblxc bases the container tree on PID 1's cgroup and only special-cases systemd's init.scope/, so under Finit it landed containers in init/, with no controllers available. Issue #497 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Contributor
|
can confirm that |
Collaborator
Author
Excellent! Then that's the way to go, thank you for taking the time to verify! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly fixes #497