Skip to content

Rework resolve method #52

Open
Open

Description

@jgaehring

As I mentioned in #22 (comment), I'm really not confident in the design of the resolve method, but I don't think it makes much sense to solidify it before farmOS/field-kit#190 is completed, so I can be sure how it will work in practice.

I suppose the most immediate concern for now is, if I anticipate major changes to this method, should I remove the documentation and/or the implementation I have now?

In the course of framing that question I think I've made up my mind... It needs to be removed; there's really no good reason to keep it.

So I've deleted the implementation, the docs and the tests for now and can revert the commit (195b3f0) when I'm ready to revisit this.

Activity

  1. added this to the 2.0.0 milestone on Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions