Skip to content

Fix stylex-sort-keys autofix ordering - #1665

Merged
mellyeliu merged 1 commit into
facebook:mainfrom
Jaksenc:codex/sort-keys-whole-object
May 20, 2026
Merged

Fix stylex-sort-keys autofix ordering#1665
mellyeliu merged 1 commit into
facebook:mainfrom
Jaksenc:codex/sort-keys-whole-object

Conversation

@Jaksenc

@Jaksenc Jaksenc commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #787.

Testing

  • npx -y -p node@22 -p yarn@1.22.22 yarn --ignore-engines jest tests/stylex-sort-keys-test.js --runInBand --no-coverage
  • npx -y -p node@22 -p yarn@1.22.22 yarn --ignore-engines eslint packages/@stylexjs/eslint-plugin/src/stylex-sort-keys.js packages/@stylexjs/eslint-plugin/tests/stylex-sort-keys-test.js
  • npx -y -p node@22 -p yarn@1.22.22 yarn --ignore-engines flow check --show-all-errors
  • git diff --check

@meta-cla

meta-cla Bot commented May 13, 2026

Copy link
Copy Markdown

Hi @Jaksenc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@vercel

vercel Bot commented May 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
stylex Skipped Skipped May 13, 2026 3:13pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2026
@meta-cla

meta-cla Bot commented May 13, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Jaksenc

Jaksenc commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

I checked the failing size and perf benchmark jobs after approval. The benchmark steps completed successfully; both jobs are red because the final peter-evans/create-or-update-comment step hit Resource not accessible by integration when trying to post the benchmark comment.

The size output is unchanged across the measured bundles (1.00 ratios throughout). The perf output shows small mixed movement (basic create 0.97, the other three entries 1.02-1.03). So this does not look like a code-caused benchmark failure from this PR.

@mellyeliu
mellyeliu merged commit 10fe3d9 into facebook:main May 20, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[eslint-plugin] sort keys rule should sort object keys when applying fix

2 participants