Repository navigation
fix Add support for Django reverse relationships for cross module #2071 - #5130
Open
asukaminato0721 wants to merge 2 commits into
Open
asukaminato0721 wants to merge 2 commits into
asukaminato0721 wants to merge 2 commits into
Conversation
Reverse relationship discovery needs an explicit list of model modules to support lazy loading. Add the configuration contract, validation, and reference documentation for that list.
Load explicitly configured model modules when solving reverse relationships and record their dependencies. This supports cross-module relations with lazy module loading and invalidation, without scanning all loaded modules.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D123799553. (Because this pull request was imported automatically, there will not be any future comments.) |
Collaborator
Author
|
todo: this will need manually add configure, is it possible to do some cold start? |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Not familiar with how the Rust code works, but will this support globs ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2071
By let user write these models down in configure.
Test Plan
add test