Repository navigation
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D123716933. (Because this pull request was imported automatically, there will not be any future comments.) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5087.
In Python, built-in singleton constants and runtime objects like
NotImplemented,Ellipsis,None, and modules do not expose their types as builtins, so users frequently writetype(...)in type annotations (or confusetype(MyClass)withtype[MyClass]).When a single-argument call to
builtins.type(...)appears in an annotation where function calls are invalid, inspect the argument type and append a helpful suggestion to theinvalid-annotationerror message:type(NotImplemented)->Did you mean `types.NotImplementedType`?type(Ellipsis)/type(...)->Did you mean `types.EllipsisType`?type(None)->Did you mean `None`?type(some_module)->Did you mean `types.ModuleType`?type(MyClass)->Did you mean `type[MyClass]`?Test Plan
Added
test_type_call_in_annotationsinpyrefly/lib/test/annotation.rsand rancargo test.