Repository navigation
Infer column dtypes with columns and schema_overrides - #5102
Open
tonyyuyiding wants to merge 2 commits into
Open
tonyyuyiding wants to merge 2 commits into
tonyyuyiding wants to merge 2 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D123393717. (Because this pull request was imported automatically, there will not be any future comments.) |
tonyyuyiding
marked this pull request as ready for review
October 5, 2026 10:11
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5036
Motivation
Originally, in
pl.read_csv, Pyrefly only infers the column dtypes ifschemais provided. However, in the case below, where we have bothcolumnsandschema_overrides, there is enough information to infer the precise schema.With this PR, Pyrefly will try to infer the schema as precisely as possible with
columnsandschema_overrides, even thoughschemais not given.Approach
The function
polars_csv_optionsis used to parse the options ofread_csvandscan_csv. In the old implementation, it assumedschemaalways exists andschema_overridesis either a sequence or absent, because the checker relied onschemato perform inference. To add the new feature, I have extended relevantenums and updated some old functions accordingly to handle more possible options. Then I added a new branch ininfer_read_csv_schemato handle the cases whereschemais missing, while the old branch was left unchanged.Test Plan
Tests have been added in
pyrefly/lib/test/polars/dataframe.rs.