Skip to content

Notebooks: insert import quick-fix should insert the import in the current cell, not the top cell #2152

Closed

Description

@yangdanny97

Describe the Bug

  1. verify that this is indeed what Pylance and other language servers do
  2. implement the change by remapping quick-fix positions based on notebook cell offsets

Sandbox Link

No response

(Only applicable for extension issues) IDE Information

No response

Activity

  1. added
    help wantedLarger than "good first issue", but still well-defined and ready for someone to pick up
    language-serverIssues specific to our IDE integration rather than type checking
    on Jan 19, 2026
  2. hanzel-sc commented on Jan 19, 2026

    @hanzel-sc
    Contributor

    I would like to work on this issue.

  3. yangdanny97 commented on Jan 19, 2026

    @yangdanny97
    CollaboratorAuthor

    assigned, thank you!

    please reference the code actions tests & the lsp_interactions notebook tests for examples on how to test this

  4. hanzel-sc commented on Jan 20, 2026

    @hanzel-sc
    Contributor

    thanks! I'll start looking into this and update here if I any questions or run into blockers.

  5. github-actions commented on Feb 4, 2026

    @github-actions

    This issue has someone assigned, but has not had recent activity for more than 2 weeks.

    If you are still working on this issue, please add a comment so everyone knows. Otherwise, please unassign yourself and allow someone else to take over.

    Thank you for your contributions!

  6. hanzel-sc commented on Mar 1, 2026

    @hanzel-sc
    Contributor

    still working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedLarger than "good first issue", but still well-defined and ready for someone to pick uplanguage-serverIssues specific to our IDE integration rather than type checkingnotebookstale

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions