Skip to content

Follow-up (#151): sweep MCP envelope consistency across update/delete tools + edge tests #12

Description

@jgruberf5

Deferred, non-blocking follow-ups from the PR #151 review (normalize MCP registration envelopes → {success, <entity>, message?}). Coordinated breaking change with awsbnkctl/internal/forge/client.go.

1. Envelope sweep — update_project, delete_project, update_cluster, delete_cluster (and likely others) still have inconsistent shapes. Sweep them to the same {success, <entity>, message?} envelope for a consistent MCP contract.

2. Edge-branch tests — add tests for the explicit success: False path and the non-dict {success: False, raw} fallback in create_project/create_cluster.

3. Harden success derivation — create_cluster hardcodes success: True; derive from status != "failed" if exposed. Tighten error passthrough to key on ok is False alone.

Source: PR #151 review (mwiget).


Migrated from sp-prod-field/bnk-forge #156 (opened 2026-05-26; original labels: enhancement). That repository is archived and read-only.
Bare #NNN references in the text above refer to issues and PRs in the original repository, not to numbering here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew capability or improvement to existing behaviourmcpMCP server and AI-agent tool surface

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions