internationalization is not working for buttons #96

Activity

1. welcome commented on Aug 23, 2022

   

   welcomebot

   on Aug 23, 2022

   More actions

   Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗
   
   If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
   
   If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
   
   Welcome to the EBP community! 🎉
2. chrisjsewell commented on Aug 23, 2022

   

   chrisjsewell

   on Aug 23, 2022

   Member

   More actions

   Heya, well I'm happy to take PRs 🙏, but I'm not sure if will get round to figuring it out myself so soon
3. jpmckinney commented on Dec 8, 2022

   

   jpmckinney

   on Dec 8, 2022

   Last edited by jpmckinney

   Contributor

   More actions

   I thought maybe the extra inline might have been causing issues but even with code like (breaks buttons that contain non-plaintext - just for testing):

            if self.content:
   -            textnodes, _ = self.state.inline_text(
   -                "\n".join(self.content), self.lineno + self.content_offset
   -            )
   -            content = nodes.inline("", "")
   -            content.extend(textnodes)
   +            content = nodes.Text("\n".join(self.content))
            else:
   -            content = nodes.inline(target, target)
   +            content = nodes.Text(target)
            node.append(content)

   The above code generates what Sphinx references tend to look like, for the source (English) language:

                <reference classes="sd-sphinx-override sd-btn sd-text-wrap" refuri="https://example.com">
   -                <inline>
   -                    Button text
   +                Button text

   But using @damian-krawczyk's project as an example, the reference seems to get entirely eliminated and only the text node is rendered in the translation...

   <paragraph>Przykładowy przycisk</paragraph>
4. jpmckinney commented on Dec 8, 2022

   

   jpmckinney

   on Dec 8, 2022

   Contributor

   More actions

   Also, I don't know why Sphinx extracts :bdg-link-primary-line: as part of the translatable message for the badge.
5. ferrine commented on Jul 14, 2023

   

   ferrine

   on Jul 14, 2023

   More actions

   Is there any progress on this?
6. sneakers-the-rat commented on May 19, 2026

   

   sneakers-the-rat

   on May 19, 2026

   Contributor

   More actions

   as a temporary workaround, just using the generated html directly fixes the problem: pyOpenSci/python-package-guide#664 (comment)

   but that's pretty janky. I don't know docutils internals well enough to know what's going wrong with i18n here - the .po files seem to correctly extract the link text, it's just the outer DOM elements that get wreck'd

   👀React with 👀1Reacted by Leah Wasser
7. chrisjsewell

   added 4 commits that reference this issue on Jul 12, 2026

   🐛 FIX: keep buttons intact under gettext translation

   ...

   This issue will close once commit 9b26f54 is merged into the 'main' branch.

   9b26f54

   🐛 FIX: keep buttons intact under gettext translation

   ...

   This issue will close once commit 20bbe88 is merged into the 'main' branch.

   20bbe88

   🐛 FIX: keep buttons intact under gettext translation

   ...

   This issue will close once commit 65281b4 is merged into the 'main' branch.

   65281b4

   🐛 Keep buttons intact under gettext translation (#270)

   ...

   This issue will close once commit 834eebe is merged into the 'main' branch.

   834eebe
8. chrisjsewell

   closed this as completedin #270on Jul 12, 2026