sentry/execution: requeue transactions that gain data late - #884
Open
damilolaedwards wants to merge 1 commit into
Open
sentry/execution: requeue transactions that gain data late#884damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
A transaction seen hash-only over the websocket subscription and later enriched with data from a poller was supposed to be requeued for processing once it had data. The requeue check compared record.TxData against nil, but an earlier line in the same branch had already written the new data into record.TxData, so the check always saw non-nil and the transaction was never requeued. It stayed in pendingTxs, fully hydrated, until the age-based pruner quietly dropped it. Capture whether the record just gained data before mutating it, and use that captured value for the requeue decision instead of re-reading the field afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A transaction seen hash-only over the websocket subscription and later enriched with data from a poller was supposed to be requeued for processing once it had data. The requeue check compared record.TxData against nil, but an earlier line in the same branch had already written the new data into record.TxData, so the check always saw non-nil and the transaction was never requeued. It stayed in pendingTxs, fully hydrated, until the age based pruner quietly dropped it.
Capture whether the record just gained data before mutating it, and use that captured value for the requeue decision instead of re-reading the field afterward.
Test plan
go build ./...go test ./pkg/sentry/execution/... -race