Drop named-fork entries from EL blob schedule (geth 1.17.5 compat) - #826
Closed
barnabasbusa wants to merge 2 commits into
Closed
Drop named-fork entries from EL blob schedule (geth 1.17.5 compat)#826barnabasbusa wants to merge 2 commits into
barnabasbusa wants to merge 2 commits into
Conversation
barnabasbusa
commented
Aug 7, 2026
Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
qu0b
approved these changes
Aug 7, 2026
barnabasbusa
added a commit
that referenced
this pull request
Aug 7, 2026
Collaborator
Author
|
Closing in favor of #814, which now carries this change (the blob-schedule fix branch was merged into the dependabot branch there). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-ethereum v1.17.5 removed the named-hardfork fields (
Osaka,Amsterdam,UBT) fromparams.BlobScheduleConfig(ethereum/go-ethereum#35029 "Remove named hardforks from the BPO schedule"). Named forks no longer carry their own blob schedule; they inherit from the BPO chain below them.This PR removes the three rows referencing those fields from the fork table in
GetFullBlobSchedule(clients/execution/chainstate.go), keeping Cancun, Prague, and BPO1-5. It still compiles against the currently-pinned v1.17.4 and unblocks the dora side of the dependabot bump in #814.Why this is behavior-safe
Both consumers of
GetFullBlobScheduleare unaffected:GetBpoForks(services/chainservice_forks.go) only uses entries withIsBpo == true; the removed rows were all non-BPO.GetBlobScheduleForTimestamppicks the last entry before a timestamp. Under geth's new model a named fork never changes blob params — its schedule always equals the preceding BPO/Prague/Cancun entry — so those rows were redundant duplicates.Notes
The go-ethereum bump itself is not included here; it remains blocked on an ethcore update for geth 1.17.5, which is in progress separately.