Skip to content

test: add error location assertion for relative-font-units - #521

Merged
DMartens merged 1 commit into
eslint:mainfrom
KumJungMin:feat/enforce-test
Aug 2, 2026
Merged

DMartens merged 1 commit into
eslint:mainfrom
KumJungMin:feat/enforce-test

Conversation

@KumJungMin

@KumJungMin KumJungMin commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Adds location assertions to the relative-font-units rule tests to ensure errors are reported at the correct source locations.

What changes did you make? (Give an overview)

Added line, column, endLine, and endColumn assertions to invalid test cases for the relative-font-units rule.

Related Issues

Refs eslint/eslint#21102

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Aug 2, 2026
@KumJungMin
KumJungMin marked this pull request as draft August 2, 2026 12:46
@KumJungMin
KumJungMin marked this pull request as ready for review August 2, 2026 12:53

@DMartens DMartens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@DMartens
DMartens merged commit 0194c23 into eslint:main Aug 2, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage Aug 2, 2026
@KumJungMin
KumJungMin deleted the feat/enforce-test branch August 9, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants