jdk 25 and spring boot 4.1 - #697
Merged
Merged
Conversation
spring-cloud-gcp 8.1.0 is the same code as 7.4.10 rebuilt against Spring Boot 4; 7.4.10 compiles against spring-boot-autoconfigure 3.5.3. The chart gains the JDK 25 native-access and Unsafe flags, guarded by IgnoreUnrecognizedVMOptions so the chart still boots if it ever meets a pre-JDK-24 image. New docker-smoke job starts the built image and gates docker-push, since nothing else in CI runs it.
There was a problem hiding this comment.
Pull request overview
Updates Baba’s build/runtime stack to Java 25 and aligns dependencies/CI with Spring Boot 4.1-era components, including a new CI smoke test that actually runs the built Docker image before allowing pushes.
Changes:
- Bump parent
superpomand Spring Cloud GCP BOM to versions compatible with Spring Boot 4.x. - Move CI and Docker runtime to Liberica OpenJRE 25.0.4 and add a Docker image smoke test gating
docker-push. - Update Helm deployment JVM options to include native-access/Unsafe-related flags; update repo developer guidance to Java 25.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Upgrades parent superpom and Spring Cloud GCP BOM version for Spring Boot 4.x compatibility. |
helm/baba/templates/deployment.yaml |
Extends JVM options passed via JDK_JAVA_OPTIONS for newer JDK behavior. |
Dockerfile |
Switches base images from JRE 21 to JRE 25 for build/run stages. |
CLAUDE.md |
Updates documented build JDK from 21 to 25. |
.github/workflows/push.yml |
Updates actions and Java version; adds docker-smoke job and gates docker-push on it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring-cloud-gcp 8.1.0 is the same code as 7.4.10 rebuilt against Spring Boot 4; 7.4.10 compiles against spring-boot-autoconfigure 3.5.3. The chart gains the JDK 25 native-access and Unsafe flags, guarded by IgnoreUnrecognizedVMOptions so the chart still boots if it ever meets a pre-JDK-24 image. New docker-smoke job starts the built image and gates docker-push, since nothing else in CI runs it.