Skip to content

Remove vk::pipeline_bind_point as an explicit parameter #89

Description

@mrparmesan01

Task Brief

Currently, vk::pipeline manage their own underlying VkPipeline handles. In the existing APIs, pipeline instance handles are coupled with binding operations, require an explicit binding point parameter.

The source for removing the explicit binding point parameter can be viewed here:

pipeline_bind_point::graphics) {

API Changes

Currently, the implementation couples the pipeline are coupled by command buffer and requires explicit binding point specification:

m_graphics_pipeline.bind(m_current_command, vk::pipeline_bind_point::graphics);

The newer API shifts to having these executed context to the command buffer and deducing the binding point based on a dedicated API with the specific binding point:

m_current_command.bind_graphics_pipeline(m_graphics_pipeline);

Task Completion Expectation

  • vk::pipeline and other VkPipelinewrappers will no longer expose a bind API requiring explicit binding points.
  • vk::command_buffer will be responsible for handling bind operations and dedicated APIs for explicitly binding specific pipelines.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    💳 Tech DebtTasks that have some kind of user API tech debt📐designTasks that involve the core systems. Highly involve in API design.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions