Repository navigation
Grant the player effectively infinite lives - #1963
Merged
Merged
Conversation
We currently have a partial implementation of lives in the game. The player starts with 3 lives; they lose a life each time they are defeated; and when they run out of lives, they are kicked back to the start of the current challenge. However, we have no visible indication of the number of lives the player has remaining. As a result, the game feels broken when the player unexpectedly loses their progress after being defeated. In addition, some recent playtesters felt that the game-over behaviour is unfair, even if it were visible. For now, set the number of lives to be effectively infinite (the largest positive integer that Godot can represent), to effectively disable the feature. This hexadecimal number is 9,223,372,036,854,775,807 (9 quintillion) in decimal. Helps #1957
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/grant-the-player-effectively-infinite-lives. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
Author
|
Note that this is 9 quintillion in the short scale; in the long scale it is 9 trillion. |
manuq
approved these changes
Feb 20, 2026
| const COMPLETED_QUESTS_KEY := "completed_quests" | ||
| const LIVES_KEY := "current_lives" | ||
| const MAX_LIVES := 3 | ||
| const MAX_LIVES := 0x7fffffffffffffff |
Collaborator
There was a problem hiding this comment.
Yes, smart. Simpler than reverting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have a partial implementation of lives in the game. The player starts with 3 lives; they lose a life each time they are defeated; and when they run out of lives, they are kicked back to the start of the current challenge.
However, we have no visible indication of the number of lives the player has remaining. As a result, the game feels broken when the player unexpectedly loses their progress after being defeated.
In addition, some recent playtesters felt that the game-over behaviour is unfair, even if it were visible.
For now, set the number of lives to be effectively infinite (the largest positive integer that Godot can represent), to effectively disable the feature. This hexadecimal number is 9,223,372,036,854,775,807 in decimal: 9 quintillion in the short scale.
Helps #1957