Repository navigation
Prefix quest files (not dirs) with quest name - #1357
Conversation
|
Play this branch at https://endlessm.github.io/threadbare/branches/endlessm/wjt/prefix-quest-files-not-dirs-with-quest-name. (This launches the game from the start, not directly at the change(s) in this pull request.) |
|
For a future consideration(not now) , to address this inflexibility with names, we could explore allowing the learner to select the folders they'd like to auto-copy/rename (still with an option or check box to copy all if desired). This would allow teams to have the option to incrementally grab what they need instead of all at once. "What would you like for your StoryQuest? Choose from the list, give us a name for your SQ and we will take it from there". |
|
@jgbourque but for now - shall we change the behaviour in the way implemented here? |
|
For now I think we should: "Compromise on including the quest name in the filename, to make it always visible when the filename is shown, but not in the intermediate folders: With a fairly tight character limit to remove the possibility of super long filenames throughout the learner SQ folder. |
Previously, bootstrapping a quest named "dennis" would copy scenes/quests/story_quests/NO_EDIT/1_NO_EDIT_stealth/NO_EDIT_stealth_components/NO_EDIT_stealth.dialogue to scenes/quests/story_quests/dennis/1_stealth/stealth_components/stealth.dialogue. This doesn't match what we have been teaching students to do by hand, which is to name scenes/quests/story_quests/dennis/1_dennis_stealth/dennis_stealth_components/dennis_stealth.dialogue. Compromise on including the quest name in the filename, to make it always visible when the filename is shown, but not in the intermediate folders: scenes/quests/story_quests/dennis/1_stealth/stealth_components/dennis_stealth.dialogue. This does have the disadvantage that if a learner later chooses to rename their quest, they now have to rename every file rather than just its root folder.
Currently, if someone calls their StoryQuest “Hurrah! Another Year, Surely This One Will Be Better Than the Last; The Inexorable March of Progress Will Lead Us All to Happiness” the resulting quest is stored in a folder called (line-wrapped for legibility): scenes/quests/story_quests/hurrah_another_year_surely_this_one_will_be_better_ than_the_last_the_inexorable_march_of_progress_will_lead_us_all_to_happiness Introduce a new field to the dialog which allows editing the folder name. Pre-populate it with the generated name whenever the title is changed. Set a maximum length on the field and truncate the generated name to that length, too. Add some new validation for problems that would previously be impossible. (This splits the validation function awkwardly in two; we can refactor this later, sorry.) This has the added bonus that if someone tries to name a quest “Sueños de Helado”, the generated folder will still be `sue_os_de_helado`, but the creator can manually edit it to `suenios_de_helado`.
64b6cd5 to
3096737
Compare
|
OK, I implemented something slightly more than that. The folder name is now truncated to 20 characters: 
But you can edit the generated folder name! This means that if it's truncated in an awkward place, you can fix it. So “Susan and the Missing Moon” would be 
But you could change it to e.g. 
|
|
I chose the limit of 20 characters because |
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Excellent, I'm looking forward for an ice cream dreams story quest!
| bg_color = Color(0, 0, 0, 1) | ||
|
|
||
| [node name="StoryQuestDialogue" type="Window"] | ||
| oversampling_override = 1.0 |
There was a problem hiding this comment.
No - but Godot really really wants to set this whenever I open and save the scene.
|
This is great thanks @wjt |
|
@jgbourque @Stregoica777 I suggest that (in your guide and on Discord perhaps) you ask mentors/students to make sure to sync their fork before trying to use this tool. And if they don't have the separate "folder name" and "full path" fields, stop: they might be using the older version that doesn't copy the challenges. |
Previously, bootstrapping a quest named "dennis" would copy
scenes/quests/story_quests/NO_EDIT/1_NO_EDIT_stealth/NO_EDIT_stealth_components/NO_EDIT_stealth.dialoguetoscenes/quests/story_quests/dennis/1_stealth/stealth_components/stealth.dialogue.This doesn't match what we have been teaching students to do by hand, which is to name
scenes/quests/story_quests/dennis/1_dennis_stealth/dennis_stealth_components/dennis_stealth.dialogue.Compromise on including the quest name in the filename, to make it always visible when the filename is shown, but not in the intermediate folders:
scenes/quests/story_quests/dennis/1_stealth/stealth_components/dennis_stealth.dialogue.This does have the disadvantage that if a learner names their quest “It was the best of time, it was the worst of times” then all the filenames will begin with
it_was_the_best_of_times_it_was_the_worst_of_times, and if they want to change this they have to rename ~66 files, whereas with the previous behaviour, they would only have to rename the quest's root folder of their quest.