Skip to content

Play Mothsache sound effect when the attack animation triggers #1020

Closed
Task
#2802
Closed
Play Mothsache sound effect when the attack animation triggers#1020
Task
#2802
Assignees
Brandon-code96
Labels
Core Gameplay & Mechanics
Milestone
UTP CGM 4.0

Description

@saspiers
saspiers
opened on Aug 9, 2025

The sound effect from #1019 should trigger when the enemy attack animation is triggered.

XP Summary (total 175)

Subdomain Skill XP
Game Design: Core Gameplay & Mechanics Problem Solving 50
Game Design: Core Gameplay & Mechanics Creativity & Design Thinking 50
Game Design: Core Gameplay & Mechanics Technical Literacy 75

Activity

  1. saspiers
    added this to Threadbare Developmenton Aug 9, 2025
  2. saspiers
    added
    Music & Sound
    on Aug 9, 2025
  3. saspiers
    added a parent issue on Aug 9, 2025
  4. saspiers
    added the
    Task
    issue type on Aug 9, 2025
  5. github-project-automation
    moved this to Untriaged in Threadbare Developmenton Aug 9, 2025
  6. saspiers
    changed the title [-]Make enemy attack SFX when the attack animation triggers[/-] [+]Make enemy attack sound effect (SFX) when the attack animation triggers[/+] on Aug 9, 2025
  7. wjt
    marked this as blocked by 4 issues on Sep 3, 2025
  8. wjt
    added
    Core Gameplay & Mechanics
    and removed
    Music & Sound
    on Oct 15, 2025
  9. wjt
    moved this from Untriaged to Todo in Threadbare Developmenton Oct 15, 2025
  10. wjt
    changed the title [-]Make enemy attack sound effect (SFX) when the attack animation triggers[/-] [+]Play Mothsache sound effect (SFX) when the attack animation triggers[/+] on Jan 12, 2026
  11. wjt
    changed the title [-]Play Mothsache sound effect (SFX) when the attack animation triggers[/-] [+]Play Mothsache sound effect when the attack animation triggers[/+] on Jan 12, 2026

  12. 2 remaining items

  13. Brandon-code96 commented on Aug 24, 2026

    @Brandon-code96
    Brandon-code96
    on Aug 24, 2026
    Contributor

    Done with the planning sheet. Ready for feedback and approval!
    https://docs.google.com/document/d/1obSxrYhMMn4dwxYuo6FnrSR6bm1kz5cxFF0xHy5yk2g/edit?usp=sharing

  14. manuq commented on Aug 27, 2026

    @manuq
    manuq
    on Aug 27, 2026
    Collaborator

    @Brandon-code96 the planning sheet is for your personal use. Please ask anything you need here directly!

  15. Brandon-code96
    added a commit that references this issue on Aug 28, 2026

    feat(enemy): play Mothsache attack sound effect on player detection e…

    a02c23e

  16. Brandon-code96 commented on Aug 28, 2026

    @Brandon-code96
    Brandon-code96
    on Aug 28, 2026
    Contributor
    Image "Hi! I've just completed this task by implementing the Mothsache attack sound effect with a looping setup when the enemy detects and chases the player. I've also opened the Pull Request with the changes.

    Attached is a screenshot showing the implementation. Could you please review it? Once confirmed, I'm ready to start working on another issue. Thanks!"

  17. manuq commented on Aug 28, 2026

    @manuq
    manuq
    on Aug 28, 2026
    Collaborator

    @Brandon-code96 yes, reviewed. Please link the issue from the pull request adding "Resolve ..." as last line, like our contributing guide explains.

  18. wjt
    added this to the UTP CGM 4.0 milestone on Sep 3, 2026
  19. Brandon-code96
    added a commit that references this issue on Sep 9, 2026

    feat(enemy): play Mothsache attack sound effect on player detection e…

    4c2f5c3

  20. Brandon-code96 commented on Sep 9, 2026

    @Brandon-code96
    Brandon-code96
    on Sep 9, 2026
    Contributor

    Hi @manuq,

    I have updated the pull request to address your feedback:

    • Cleaned up all unintended system and resource modifications by working exclusively within the recommended Godot v4.7.2 environment.
    • Re-implemented the Mothsache attack sound logic cleanly, leaving only the required audio and component files in the commit history.
    • Synchronized the branch with the latest changes.

    Could you please take another look when you have a moment? Thank you!

  21. manuq commented on Sep 10, 2026

    @manuq
    manuq
    on Sep 10, 2026
    Collaborator

    @Brandon-code96 yes I just did. Sorry I haven't seen this message before commenting:

    Next time click "Request" or leave us a comment to let us know.

    You certainly did. Thanks!

  22. Brandon-code96
    added a commit that references this issue on Sep 12, 2026

    fix(enemy): fix audio import, remove setter, and apply pre-commit for…

    0001562

  23. Brandon-code96 commented on Sep 14, 2026

    @Brandon-code96
    Brandon-code96
    on Sep 14, 2026
    Contributor

    "Hi @manuq! Thanks for the feedback. I've updated the PR by assigning the audio stream directly to the AudioStreamPlayer2D node, cleaning up the unused setter function, fixing the audio loop/noise issue, and running pre-commit to clear the formatting errors. It's ready for another look whenever you have time. Thank you!"

  24. manuq
    added a commit that references this issue on Sep 14, 2026

    Enemy: Play Mothsache attack sound effect on player detection (#2802)

    26b6366
  25. manuq
    closed this as completedin #2802on Sep 14, 2026
  26. github-project-automation
    moved this from Todo to Done in Threadbare Developmenton Sep 14, 2026

  27. manuq commented on Sep 14, 2026

    @manuq
    manuq
    on Sep 14, 2026
    Collaborator

    @Brandon-code96 excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Core Gameplay & Mechanics

Type

Task

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions