Move NODE_CODE_CACHING check to INCOMPATIBLE_SETTINGS - #27734
Merged
Merged
Conversation
Move the `WASM_ASYNC_COMPILATION` incompatibility check for `NODE_CODE_CACHING` from `tools/link.py` to `INCOMPATIBLE_SETTINGS` in `tools/settings.py` (following up on emscripten-core#27670). Also remove the `ENVIRONMENT_MAY_BE_NODE` error check for `NODE_CODE_CACHING` in `tools/link.py`. This allows the existing `unused-command-line-argument` warning (added in emscripten-core#18820) to be reached when `node` is not in `ENVIRONMENT`, matching the behavior of `NODERAWFS` and `NODERAWSOCKETS`.
kripken
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
WASM_ASYNC_COMPILATIONincompatibility check forNODE_CODE_CACHINGfromtools/link.pytoINCOMPATIBLE_SETTINGSintools/settings.py(following up on #27670).Also remove the
ENVIRONMENT_MAY_BE_NODEerror check forNODE_CODE_CACHINGintools/link.py. This allows the existingunused-command-line-argumentwarning (added in #18820) to be reached whennodeis not inENVIRONMENT, matching the behavior ofNODERAWFSandNODERAWSOCKETS.