Conversation
Usage of triple vs. double equalities in shell.js was inconsistent. In all cases where `==` and `!=` were used in the file, `===` and `!==` are more appropriate. At a minimum, the non-coercive equality checks show intention more clearly. They also are generally faster, though this is unlikely to matter in shell.js.
Collaborator
|
As unusual as it sounds we actually deliberately use Sorry, I know if its kind of gross and goes against JS best practices, but we this code is included with every emscripten program, so if we can save even a couple of bytes here we do. |
Collaborator
|
If we were to change our policy here we should also so it across the entire codebase, and not just in shell.js. |
Author
|
@sbc100 Understood. Feel free to close this PR. This might be worth a wider discussion, but certainly it's not too important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage of triple vs. double equalities in shell.js was inconsistent. In all cases where
==and!=were used in the file,===and!==are more appropriate.At a minimum, the non-coercive equality checks show intention more clearly. They also are generally faster, though this is unlikely to matter in shell.js.