Skip to content

docs: tighten metric_stability docs to match the implementation - #2362

Open
joostboon wants to merge 1 commit into
docsfrom
metric-stability-docs-accuracy
Open

joostboon wants to merge 1 commit into
docsfrom
metric-stability-docs-accuracy

Conversation

@joostboon

Copy link
Copy Markdown

Checked docs/data-tests/metric-stability.mdx against test_metric_stability.sql and metric_stability_query.sql on dbt-data-reliability master (5d22e8d9). The page is accurate; this fixes three spots where it was looser than the code.

  • backfill_days: on incremental models and sources, a value below the window derived from min_bucket_age raises a compile error (resolve_metric_stability_window); the page only said it reduces coverage. Also documents that force_metrics_backfill re-measures the full days_back window.
  • timestamp_column: can be inherited from the model's Elementary config (get_test_argument), not only set on the test.
  • Metric history: stored with collected_by="metric_stability" in metric_properties, so it is not shared with anomaly tests' metrics. Replaced "reusing Elementary's metric caching", which suggested otherwise.

🤖 Generated with Claude Code

- backfill_days below the derived minimum raises an error on incremental
  models and sources; document force_metrics_backfill
- timestamp_column can be inherited from the model's Elementary config
- metric history is kept separately from anomaly tests' metrics

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 23189db3-a5a6-4edf-be45-23194289ceba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant