chore: remove new-pr label and 24 hour rule - #239
Merged
Merged
Conversation
Removes the `new-pr 🌱` label and everything that existed to manage
it (24 hour rule handler, its cron, exclusion lists, tests, fixtures,
README section).
API review used that label as its minimum open time gate, so that
gate is now time based instead. `checkPRReadyForMerge` compares
against the same ready time the check title already shows ("ready on
<date>"): opened / last marked ready for review + 7 days.
Things that behave differently:
* `api-review/skip-delay ⏰` now actually skips the delay. Previously
it only changed the date in the check title and the real bypass was
`fast-track` / `backport` removing `new-pr`.
* The 5 minute cron lives in `setupAPIReviewStateManagement` now and
only looks at open PRs that have an `api-review/*` label.
* The old cron paginated from `page = 0` which GitHub treats as page
1, so the first 100 PRs were processed twice per run. Switched to
`octokit.paginate`.
The `new-pr 🌱` label itself will need deleting from
electron/electron by hand after this deploys.
MarshallOfSound
enabled auto-merge (squash)
September 12, 2026 02:25
nmggithub
previously requested changes
Sep 12, 2026
nmggithub
left a comment
There was a problem hiding this comment.
Astra tells me of this one correctness issue:
- [P2] Revoke existing approval when the delay applies again —
src/api-review-state.ts, lines 411–418. If a young PR is approved usingapi-review/skip-delayand that label is subsequently removed, this early return preservesapi-review/approvedand the successful check until day seven. It also ignores subsequent API declines or change requests during that period. Reset premature approval to requested, and allow negative review outcomes to take effect. I reproduced the stale approval with a one-day-old PR and a subsequent decline.
MarshallOfSound
dismissed
nmggithub’s stale review
September 12, 2026 02:41
this is completely unrelated to the act of removing the new-pr feature and exists before this change. dismissing review
nmggithub
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
new-pr 🌱label and everything that existed to manage it (24 hour rule handler, its cron, exclusion lists, tests, fixtures, README section).API review used that label as its minimum open time gate, so that gate is now time based instead.
checkPRReadyForMergecompares against the same ready time the check title already shows ("ready on "): opened / last marked ready for review + 7 days.Things that behave differently:
api-review/skip-delay ⏰now actually skips the delay. Previously it only changed the date in the check title and the real bypass wasfast-track/backportremovingnew-pr.setupAPIReviewStateManagementnow and only looks at open PRs that have anapi-review/*label.page = 0which GitHub treats as page 1, so the first 100 PRs were processed twice per run. Switched tooctokit.paginate.The
new-pr 🌱label itself will need deleting from electron/electron by hand after this deploys.