Skip to content

Fix "setState during render" warning #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexandrHoroshih merged 3 commits into from
Sep 16, 2023
Merged

Fix "setState during render" warning #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0908c20
Add a command for easier launch of playground app
AlexandrHoroshih Sep 16, 2023
582cdee
Fix empty header in the playground app
AlexandrHoroshih Sep 16, 2023
8d72c90
Delay state update for one tick to evade setState warning
AlexandrHoroshih Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/playground-app/src/shared/app/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const pageStarted = createEvent<{

export const $currentPage = createStore<(typeof pageTypes)[number] | null>(null).on(
pageStarted,
(_, { pageType }) => pageType
(_, { pageType }) => pageType ?? "unknown_page"
);

export function declarePage<Ctx = void>(config: {
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"build:code": "vite build",
"build:types": "tsc",
"build:directive": "node ./scripts/inject-use-client.mjs",
"build": "pnpm build:code && pnpm build:types && pnpm build:directive"
"build": "pnpm build:code && pnpm build:types && pnpm build:directive",
"dev:playground-app": "cd apps/playground-app && pnpm dev"
},
"devDependencies": {
"@babel/core": "^7.21.4",
Expand Down
14 changes: 13 additions & 1 deletion src/get-scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,19 @@ function HACK_updateScopeRefs(tscope: Scope, values: Values) {
}

/**
* Run scheduled watchers
* Delay links run to separate task,
* so React won't agro on us for updating state during render
*/
queueMicrotask(() => {
HACK_runScopeWatchers(scope, linksToRun);
});
}

function HACK_runScopeWatchers(scope: ScopeInternal, linksToRun: string[]) {
/**
* Run watchers (`useUnit`, etc) to push new values to them
*
* Manual lauch is required because top-down re-render stops at `memo`-ed components
*/
if (linksToRun.length) {
linksToRun.forEach((nodeId) => {
Expand Down