Repository navigation
Fix chat prompt partly covered by the mode line - #330
Conversation
aed1d74 to
806ac13
Compare
806ac13 to
68d0a25
Compare
|
@shohi can you explain how can I repro the issue you were having? |
|
@ericdallo The issue is that a multiline prompt can become partly hidden behind the mode line. There are two ways to reproduce it on the version before this PR: While typing
While streaming
In both cases, I expect the window to scroll enough to keep the prompt end fully visible without moving the cursor. That is what this PR fixes. |
68d0a25 to
0cbe069
Compare
|
@shohi I still can't repro that Any chance this is related with your config or your modeline? |
f1afd8d to
0ceb6cd
Compare
Streamed text is inserted above the prompt and pushes it down. Redisplay only keeps the line of point visible, so when point sits on an early line of a multiline prompt, the lines below it slide under the mode line. When point is in the prompt and the bottom of the chat is shown, scroll just enough to show the end of the prompt again, without moving point. Nothing scrolls while the user reads earlier content.
0ceb6cd to
b4fee8f
Compare
|
@ericdallo Thanks for trying it. You were right about the config: the typing case came from my Demo recorded with Here is a demo before and after the fix:
|


Changes