Need for additional dependencies when using score_tooling #82

Activity

1. umaucher

   added the

   Bug

   issue type on Oct 31, 2025
2. github-project-automation

   added this to INF - Infrastructure Communityon Oct 31, 2025
3. github-project-automation

   moved this to Draft in INF - Infrastructure Communityon Oct 31, 2025
4. RamakrishnanPK

   self-assigned this

   on Aug 24, 2026
5. RamakrishnanPK commented on Aug 24, 2026

   

   RamakrishnanPK

   on Aug 24, 2026

   More actions

   @umaucher - I can see already present in the main.

   bazel_dep(name = "aspect_rules_lint", version = "2.5.0")
   bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
   

   Is this issue still valid?
6. RamakrishnanPK

   moved this to refinement needed in INF - Infrastructure Communityon Sep 21, 2026
7. umaucher commented on Oct 6, 2026

   

   umaucher

   on Oct 6, 2026

   ContributorAuthor

   More actions

   Still valid with score_tooling 2.3.1:

   use_format_targets() in third_party/format/macros.bzl passes the formatter labels as plain strings. These resolve in the consumer's repo mapping, so consumers still need their own bazel_deps:

   $ bazel build //:format.check
   ERROR: ... No repository visible as '@aspect_rules_lint' from main repository
   

   Fix: wrap the labels in Label() so they resolve in score_tooling's repo. Verified in persistency with both deps removed and --override_module=score_tooling=<local>: format.check passes (fails without the patch).

    _FORMATTERS = {
   -    "python": ("python", "@aspect_rules_lint//format:ruff"),
   -    "rust": ("rust", "@score_tooling//third_party/format:rustfmt_with_policies"),
   -    "starlark": ("starlark", "@buildifier_prebuilt//:buildifier"),
   -    "yaml": ("yaml", "@aspect_rules_lint//format:yamlfmt"),
   +    "python": ("python", Label("@aspect_rules_lint//format:ruff")),
   +    "rust": ("rust", Label("//third_party/format:rustfmt_with_policies")),
   +    "starlark": ("starlark", Label("@buildifier_prebuilt//:buildifier")),
   +    "yaml": ("yaml", Label("@aspect_rules_lint//format:yamlfmt")),
   +    # Plain string: the `llvm` extension is root-module-only, so @llvm_toolchain must come from the consumer.
        "cpp": ("cc", "@llvm_toolchain//:clang-format"),
    }

   Notes:

   • cpp stays a plain string: toolchains_llvm only allows its llvm extension in the root module, so score_tooling can't provide @llvm_toolchain.
   • The standalone score_format_checker module is obsolete (registry-marked) and has the same flaw. Consumers should load @score_tooling//third_party/format:macros.bzl instead.