Repository navigation
Move score_tooling dev targets to tools/BUILD - #222
Merged
Merged
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
lavrovvalera
approved these changes
Sep 17, 2026
PiotrKorkus
approved these changes
Sep 17, 2026
PiotrKorkus
left a comment
PiotrKorkus
left a comment
There was a problem hiding this comment.
or docs() target can be moved to docs/BUILD - same effect (docs is separated from dev_dependencies) but less code moved.
Both solutions should do the job - up to you @antonkri
antonkri
added a commit
that referenced
this pull request
Sep 18, 2026
score/time_slave/tests/reference_integration/ is built specifically for consumption by reference_integration's per-module unit-test sweep (@score_time//score/...). Its BUILD files load() score_itf, rules_pkg, score_rules_imagefs and nlohmann_json, but all four were only declared as dev_dependency = True in this module's own MODULE.bazel. Once score_time is used as a non-root module (e.g. by reference_integration), those repos become invisible and package loading fails before target selection even starts - identical failure mode to the score_tooling issue fixed for the root BUILD in #222. Drop dev_dependency = True from the four bazel_deps (plus the standalone flag on the json_schema_validator http_archive, which needs nlohmann_json to load its own BUILD file). The imagefs/oci module extensions themselves stay dev_dependency - only the repos need to be visible for load().
PiotrKorkus
pushed a commit
that referenced
this pull request
Sep 18, 2026
score/time_slave/tests/reference_integration/ is built specifically for consumption by reference_integration's per-module unit-test sweep (@score_time//score/...). Its BUILD files load() score_itf, rules_pkg, score_rules_imagefs and nlohmann_json, but all four were only declared as dev_dependency = True in this module's own MODULE.bazel. Once score_time is used as a non-root module (e.g. by reference_integration), those repos become invisible and package loading fails before target selection even starts - identical failure mode to the score_tooling issue fixed for the root BUILD in #222. Drop dev_dependency = True from the four bazel_deps (plus the standalone flag on the json_schema_validator http_archive, which needs nlohmann_json to load its own BUILD file). The imagefs/oci module extensions themselves stay dev_dependency - only the repos need to be visible for load(). Co-authored-by: antonkri <antonkri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request restructures Bazel development tooling by moving tool targets (copyright, formatting, license checks) out of the root BUILD file into a new tools/BUILD file. This change helps keep the root build configuration free from dev dependencies and clarifies the separation between core build logic and developer tooling. It also updates documentation, pre-commit hooks, and CI workflows to reference the new tool locations.