Prevent resuming a saved preset - #4228
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The focused preset tests, Ruff checks, and Pyright pass on the current head. The fork workflow is |
|
Thanks for enabling the fork workflow. The full |
Signed-off-by: ZenAlexa <zimingwang945@gmail.com>
|
I've synced this with current The saved preset continues to own completion and its list row; the expanded preset tests cover that behavior on the updated branch. |
Closes #4204.
What changed
dstack preset resumeonce the session has a committedpreset.yml; cleanup may leavesession.jsonatrunning,interrupted, orfailedinterrupted/faileddisplay statesWhy
PresetStore.save()atomically commits the verified artifact before run cleanup. Cleanup is already best-effort and cannot invalidate that artifact, so its interruption must not make the completed creation resumable. A genuinely interrupted session with no saved preset keeps the existing resume behavior.Verification
After syncing current
masterintoe54083b7, the preset tests use the currentsession_idfield.master.The previous head passed Pyright with zero errors.