Skip to content

docs(claude-md): repoint stale ci.yml citations to reusable workflow files - #745

Merged
drmoisan merged 6 commits into
mainfrom
bug/claude-md-cites-ciyml-for-moved-toolchain-commands-564
Sep 3, 2026
Merged

drmoisan merged 6 commits into
mainfrom
bug/claude-md-cites-ciyml-for-moved-toolchain-commands-564

Conversation

@drmoisan

@drmoisan drmoisan commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Repoint stale ci.yml citations in CLAUDE.md to reusable workflow files

Summary

Fix three stale file citations in CLAUDE.md that incorrectly reference .github/workflows/ci.yml for C# toolchain commands that were moved to separate reusable workflow files in PR #556. The citations are:

  • Line 194: CSharpier pinned-version parity reference (should cite .github/workflows/_format-check.yml, not ci.yml)
  • Line 202: .NET analyzer /t:Build /m step reference (should cite .github/workflows/_build-analyzers.yml, not ci.yml)
  • Line 210: Nullable TreatWarningsAsErrors step reference (should cite .github/workflows/_build-nullable.yml, not ci.yml)

Documentation-only change: no command text altered, no workflow behavior changed, no test coverage impact.

Why

PR #556 (issue #553) split the CI workflow into separate reusable workflow_call files to parallelize build tasks, moving the CSharpier, analyzer, and nullable-check steps out of ci.yml. CLAUDE.md's policy documentation was not updated to reflect these moves, so agents following citations to verify command compliance find stale references. This misleads developers about the authoritative location of the documented commands and is a documentation defect.

What Changed

CLAUDE.md:

  • Line 194: replaced .github/workflows/ci.yml citation with .github/workflows/_format-check.yml in the CSharpier tooling section
  • Line 202: replaced .github/workflows/ci.yml citation with .github/workflows/_build-analyzers.yml in the .NET analyzers section
  • Line 210: replaced .github/workflows/ci.yml citation with .github/workflows/_build-nullable.yml in the Type Checking section (step parenthetical "Build with nullable warnings treated as errors" retained)

No other files modified.

Verification

All 7 acceptance criteria verified and documented:

  • AC1: Select-String -Path CLAUDE.md -Pattern '_format-check\.yml' confirms exactly one match at line 194
  • AC2: Select-String -Path CLAUDE.md -Pattern '_build-analyzers\.yml' confirms exactly one match at line 202
  • AC3: Select-String -Path CLAUDE.md -Pattern '_build-nullable\.yml' confirms exactly one match at line 210; step name parenthetical retained
  • AC4: Select-String -Path CLAUDE.md -Pattern 'ci\.yml' returns zero matches (all stale citations removed)
  • AC5: git diff origin/main...HEAD -- .claude/rules/csharp.md confirms .claude/rules/csharp.md is unchanged (already correct)
  • AC6: git diff origin/main...HEAD --name-only confirms only CLAUDE.md changed; no edits under .claude/, .codex/, .agents/**, config/blast-radius.json, or config/orchestration-routing.json
  • AC7: git diff origin/main...HEAD -- CLAUDE.md shows exactly 3 removed lines and 3 added lines (only citation tokens changed; all surrounding command text preserved)

Verification evidence: 11 artifacts in docs/features/active/claude-md-cites-ciyml-for-moved-toolchain-commands-564/evidence/ documenting each check.

Backward Compatibility

No breaking changes, API changes, or migration impact. This is a documentation citation correction with no behavioral effect.

Risks & Mitigations

Risk: incorrect reusable workflow file citation(s)
Mitigation: Each citation was verified directly against the reusable workflow files to confirm the cited step exists and matches the documented command text. Low risk: single-file text revert is sufficient if correction is later found incorrect.

Follow-ups

None. Issue #564 is fully resolved by this change.

drmoisan and others added 6 commits September 2, 2026 09:16
Preparation-mode run for GitHub issue #564 (CLAUDE.md cites ci.yml for
three toolchain commands the #553 CI split moved into reusable
workflows). Adds issue.md, spec.md (full-bug, 7 AC items), a research
artifact confirming the correct citation targets against the current
tree, and an atomic plan (plan.2026-09-02T08-58.md) that repoints the
three CLAUDE.md citations to _format-check.yml, _build-analyzers.yml,
and _build-nullable.yml. Preflight cleared with PREFLIGHT: ALL CLEAR /
CONVERGENCE: NO FURTHER ROUNDS EXPECTED. Atomic execution is deferred
to parallel-orchestrator.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LTjXvNFHVh7Fo7kYGgWsx2
…dius harvest

Preparation-mode revision round for issue #564. The parallel-scheduling
blast-radius harvester reads any backtick-delimited, whitespace-free
repository-relative path as a write target regardless of surrounding
context. spec.md and the atomic plan previously quoted scope-exclusion
paths (.claude/**, .codex/**, .agents/**, config/blast-radius.json,
config/orchestration-routing.json) and reference-only citation targets
(.github/workflows/ci.yml and the three reusable workflow files) inside
backticks, so the harvester incorrectly believed this item writes the
Claude runtime tree, the Codex mirror tree, the dot-agents tree, and the
two published config files, collapsing the 13-item parallel run into
sequential cohorts.

- Add a "## Write Set" section to spec.md listing the single path this
  plan's diff actually writes: CLAUDE.md.
- Remove backtick formatting from every exclusion, verified-unchanged,
  reference-target, or context-citation path in spec.md and
  plan.2026-09-02T08-58.md, including the malformed nested-backtick
  citation tokens in P2-T1/P2-T2/P2-T3 and the Planner Self-Review
  CITATION lines. CLAUDE.md remains the only backticked path, since it
  is the only file this plan's diff creates, modifies, or deletes.
- No task, acceptance criterion, command, or evidence path changed in
  substance; this is a text-presentation-only revision.
- Append a "Revision Round" self-review section to the plan re-deriving
  the citations this pass touched, per the atomic-plan-contract
  revision-round rule.
- Re-validated via mcp__drm-copilot__validate_orchestration_artifacts
  (artifact_type: plan) and re-cleared atomic-executor preflight:
  PREFLIGHT: ALL CLEAR / CONVERGENCE: NO FURTHER ROUNDS EXPECTED.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LTjXvNFHVh7Fo7kYGgWsx2
…files (#564)\n\nCo-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>\nClaude-Session: https://claude.ai/code/session_013hACTdEjvRjdP48xdJ2B5V
Atomically persists 11 QA-gate and baseline-verification evidence artifacts from atomic-executor delivery phase. Deliverables include phase0 instruction-read record, scope-boundary declarations, and seven acceptance-criteria verification gates (AC1-AC7).

All evidence follows evidence-and-timestamp-conventions canonical location scheme under feature/evidence/. No logic changes; documentation citation fix only.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hACTdEjvRjdP48xdJ2B5V
@drmoisan
drmoisan merged commit 8be5a6a into main Sep 3, 2026
5 checks passed
@drmoisan
drmoisan deleted the bug/claude-md-cites-ciyml-for-moved-toolchain-commands-564 branch September 12, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLAUDE.md cites ci.yml for three toolchain commands the #553 split moved into reusable workflows

1 participant