Repository navigation
Bug: engine-toggle-throwing-log-sink-leaves-stale-prime-marker #947
Description
Activity
Restoring sections dropped by the promotion tooling.
Suspected Cause / Notes
The report-then-clear ordering introduced by #942 puts
_logErrorbefore_primeTasks.TryRemoveinCompletePrime, with notry/finally, so a throwing sink skips the removal. The production sink islogger.Error, so the likelihood is low. Source: #944 spec, Rollout and Follow-up item 1.Proposed Fix / Validation Ideas
- Clear the marker in a
finallyafter the report, while keeping the Bug: engine-toggle-prime-fault-logging-test-races #942 guarantee that the log precedes the observable completion. Alternatively, guard the sink call. - Regression test: a throwing sink followed by a second
GetPressedstarts a new prime. It must fail before the fix. - Sequence this after Bug: engine-toggle-prime-marker-registration-races-removal #944 merges, because the same method is touched.
- Clear the marker in a
Same root cause, second call site, found during #947 preparation and consolidated here instead of filed separately.
HandleToggleClickAsyncinTaskMaster/Ribbon/EngineToggleStateCoordinator.cscalls_logErrorwithout a guard (line ~184). A sink that throws can therefore escape a method documented as never throwing.The fix for #947 should cover both sites:
CompletePrimeandHandleToggleClickAsync. Each site needs its own regression test using a throwing sink.
Summary
After #942 moved
CompletePrimeto report the fault first and clear the marker second, alogErrorsink that throws skips the_primeTasks.TryRemove. The stale prime marker then blocks later re-primes for that engine, which is the #944 symptom by a different cause, and the continuation task faults unobserved.Environment
TaskMaster/Ribbon/EngineToggleStateCoordinator.cs,CompletePrimeSteps to Reproduce
logErrordelegate that throws.EngineActiveAsyncfaults.GetPressedagain for the same engine.Expected Behavior
The marker is cleared whether or not the log sink throws, a later
GetPressedstarts a new prime, and no task faults unobserved.Actual Behavior
The marker stays registered, no re-prime starts, and the continuation task faults unobserved.
Logs / Screenshots
Impact / Severity
Source
From: docs/features/potential/2026-09-30-engine-toggle-throwing-log-sink-leaves-stale-prime-marker.md