Repository navigation
Bug: qfcremainingqueueadmission-dead-scoreloader #622
Description
- Work Mode: minor-audit
Summary
QfcRemainingQueueAdmission accepts a scoreLoader delegate it never uses. The parameter is declared at QuickFiler/Controllers/QfcRemainingQueueAdmission.cs:17 and null-checked at QuickFiler/Controllers/QfcRemainingQueueAdmission.cs:23-26, but it is never assigned to a field and never invoked. The null check makes the dead parameter look load-bearing and forces every caller to supply a non-null delegate that cannot affect behavior, which is actively misleading when the scoring signature changes.
Environment
- OS/version:
- Python version:
- Command/flags used:
- Data source or fixture:
Steps to Reproduce
- Read
QuickFiler/Controllers/QfcRemainingQueueAdmission.cs:17and observe thescoreLoaderparameter. - Read
:23-26and observe the null guard. - Search the file for any assignment or invocation of
scoreLoaderand find none.
Expected Behavior
Either the delegate participates in admission scoring, or the parameter and its guard are removed and callers stop constructing one.
Actual Behavior
The parameter is guarded, then discarded. Callers pay the cost of building a delegate that is never called.
Logs / Screenshots
- Attached minimal logs or screenshot
- Snippet:
Impact / Severity
- Low
No runtime misbehavior; a maintainability and API-honesty defect.
Source
From: docs/features/potential/2026-08-26-qfcremainingqueueadmission-dead-scoreloader.md
Activity
drmoisan commentedon Aug 26, 2026
The promotion tool maps only a subset of the potential-entry headings into the issue body;
## Suspected Cause / Notesand## Proposed Fix / Validation Ideaswere dropped. Restoring them here so the provenance and the remediation ideas are not lost.Suspected Cause / Notes
Confirmed during issue #446 (
docs/features/active/quickfiler-bug-family-446). #446 widened the score loader to a(long Score, string TopFolder)tuple across the real consumers and specifically established that this file needed no change precisely because the parameter is never invoked. That finding is what makes the deadness certain rather than suspected. The file was not in #446's owned set.Proposed Fix / Validation Ideas
drmoisan commentedon Sep 2, 2026
Superseded by consolidated issue #731, which tracks this finding along with 4 related ones sharing the same blast radius (QuickFiler controller lifecycle/disposal). See #731 for detail.
docs(potential): record promoted records for 3 blast-radius-consolida…