Test infra improvements - #461
Merged
Merged
Conversation
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
======================================
Coverage 94.2% 94.2%
======================================
Files 23 23
Lines 1728 1728
======================================
Hits 1629 1629
Misses 99 99 |
pjbull
force-pushed
the
test-infra-improvements
branch
from
August 22, 2024 14:40
2e9fbe3 to
e33b583
Compare
Member
Author
|
@jayqi Ready, but not urgent. Thinking this can be just post-release since it is not really user-facing. I hope it improves test reliability, but in my experience failures seem to be related in some way to resource load on shared GH runners (failures seem to cluster in time). It just needs a history change added, but didn't want to collide with #463 |
This reverts commit 197a058.
pjbull
force-pushed
the
test-infra-improvements
branch
from
August 28, 2024 23:52
4d293f1 to
8045ed0
Compare
Closed
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll say this is "ready" once I get 5 error-free passes.
A few improvements: