WIP: Implement sliced downloads in GSClient - #389
Merged
pjbull merged 3 commits intoDec 29, 2023
Merged
Conversation
joconnor-ecaa
changed the title
joconnor-ecaa
marked this pull request as ready for review
December 29, 2023 09:02
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
========================================
- Coverage 93.8% 93.5% -0.4%
========================================
Files 22 22
Lines 1566 1570 +4
========================================
- Hits 1470 1468 -2
- Misses 96 102 +6
|
Member
|
Merged into |
pjbull
added a commit
that referenced
this pull request
Dec 29, 2023
* WIP: Implement sliced downloads in GSClient (#389) * feat: Implement sliced downloads in GSClient * fix: remove unintended import changes * Mock transfer_manager. Test both worker types. * Update HISTORY.md --------- Co-authored-by: Joe O'Connor <60386246+joconnor-ecaa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sliced object downloads in GSClient using
google.cloud.storage.transfer_manageras documented here.Closes #387
Contributor checklist:
CONTRIBUTING.mdCloses #issueappears in the PR summary (e.g.,Closes #123).HISTORY.mdwith the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.