Skip to content

Defer hover tracking and test selector behavior - #209

Merged
jdalton merged 1 commit into
dperini:masterfrom
jdalton:test/selector-regressions
Sep 7, 2026
Merged

jdalton merged 1 commit into
dperini:masterfrom
jdalton:test/selector-regressions

Conversation

@jdalton

@jdalton jdalton commented Sep 5, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Install hover listeners only when a hover selector is compiled. Repeated queries reuse the listeners.
  • Move the 46 Node tests into the existing unit and integration suites. Move the four browser tests into the existing e2e suite.
  • Remove the separate regression runners and stale PR-history document.
  • Update against current master without dropping either branch history.

Validation

  • Node: 540 passed, two existing expected failures, ten skipped browser tests.
  • Browser: 20 passed, two existing expected failures.
  • WPT: 54 passed.
  • Type checking and lint passed.
  • Combined coverage: 84.22% statements, 75.70% branches, 83.16% functions, and 82.97% lines. Thresholds are unchanged.

@jdalton
jdalton marked this pull request as ready for review September 5, 2026 19:42
@jdalton
jdalton force-pushed the test/selector-regressions branch 3 times, most recently from ed2e3f6 to 6966098 Compare September 6, 2026 11:40
@jdalton jdalton changed the title Preserve cross-feature selector regressions Defer hover tracking and test selector behavior Sep 7, 2026
@jdalton
jdalton force-pushed the test/selector-regressions branch from a30713f to d01d475 Compare September 7, 2026 14:52
@jdalton
jdalton merged commit 8c80ab2 into dperini:master Sep 7, 2026
jdalton added a commit that referenced this pull request Sep 17, 2026
Consolidated commits:
- adba43d Evict from the resolver caches without Map.delete (#185)
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
- 17a7467 Add opt-in legacy DOM reads and regression coverage (#203)
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
- 47bad6d perf: streamline resolver execution, query plans and DOM reads
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
- 341d50a Validate logical selector arguments before candidate matching
  Original author: jdalton <john.david.dalton@gmail.com>
- f74aaaa fix(selectors): defer hover tracking and integrate selector tests (#209)
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
- 9dcf18c perf(selectors): route simple descendant chains through scoped lookups (#206)
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
- 131347f fix(selectors): isolate lazy hover state by document (#207)
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
- abdbc83 perf(selectors): filter candidates before ancestor traversal (#189)
  Original author: John-David Dalton <jdalton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant