Skip to content

add OutputCachePolicy support - #2328

Merged
Tratcher merged 12 commits into
dotnet:mainfrom
witskeeper:main
Nov 28, 2023
Merged

add OutputCachePolicy support#2328
Tratcher merged 12 commits into
dotnet:mainfrom
witskeeper:main

Conversation

@witskeeper

Copy link
Copy Markdown
Contributor

add OutputCachePolicy to RouteConfig.cs

@Tratcher Tratcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a brief description of output caching support to the docs. You can copy timeouts or RateLimiting. Also update the TOC.
https://github.com/microsoft/reverse-proxy/tree/main/docs/docfx/articles

Comment thread src/ReverseProxy/Routing/ProxyEndpointFactory.cs Outdated
Comment thread src/Kubernetes.Controller/Converters/YarpParser.cs
Comment thread src/ReverseProxy/Configuration/RouteConfig.cs
Comment thread src/ReverseProxy/Configuration/OutputCacheConstants.cs Outdated
Comment thread docs/docfx/articles/output-caching.md Outdated
Comment thread docs/docfx/articles/output-caching.md Outdated
Comment thread docs/docfx/articles/output-caching.md Outdated
witskeeper and others added 3 commits November 18, 2023 12:28
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Comment thread docs/docfx/articles/output-caching.md Outdated
@Tratcher
Tratcher enabled auto-merge (squash) November 20, 2023 18:47

@Tratcher Tratcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this didn't update the ConfigValidator.

FYI there's a big refactor happening there right now that could cause conflicts. #2293

@witskeeper

Copy link
Copy Markdown
Contributor Author

I noticed this didn't update the ConfigValidator.

FYI there's a big refactor happening there right now that could cause conflicts. #2293

i can update the Validator after #2293 merged .

@Tratcher

Copy link
Copy Markdown
Member

#2293 has been merged.

auto-merge was automatically disabled November 23, 2023 08:08

Head branch was pushed to by a user without write access

@witskeeper

witskeeper commented Nov 23, 2023

Copy link
Copy Markdown
Contributor Author

#2293 has been merged.

done

@Tratcher Tratcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/ReverseProxy/Configuration/IYarpOutputCachePolicyProvider.cs Outdated
@Tratcher Tratcher added this to the YARP 2.x milestone Nov 28, 2023
@Tratcher
Tratcher merged commit 3853af1 into dotnet:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants