Fixing improper file format APIScan issue for DirectWriteForwarder - #11817
Open
dipeshmsft wants to merge 1 commit into
Open
Fixing improper file format APIScan issue for DirectWriteForwarder#11817dipeshmsft wants to merge 1 commit into
dipeshmsft wants to merge 1 commit into
Conversation
dotnet-policy-service
Bot
added
the
PR
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DirectWriteForwarder native project’s linker settings to address an APIScan failure (“ImproperFileFormat”) introduced after a compilation-mode change.
Changes:
- Add a Release-only linker flag (
/PROFILE) toDirectWriteForwarder.vcxprojto avoid the APIScan “ImproperFileFormat” exception.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+68
| <Link> | ||
| <AdditionalOptions Condition="'$(Configuration)'=='Release'">%(AdditionalOptions) /PROFILE</AdditionalOptions> | ||
| </Link> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the API Scan Issue - ImproperFileFormat exception in DirectWriteForwarder DLL which happened after the compilation mode shift.
Microsoft Reviewers: Open in CodeFlow