[kirsan31]

Fix #4720.

Proposed changes

• Add public bool property MdiChildrenMinimizedAnchorBottom to Form class.

Customer Impact

WinForms override standard MDI behavior without option to use original one. It's lead to all child windows layout (with minimized windows) are mess up after main window resize. This can happened after simple resize, or after resolution changed (for example if your connect by rdp from other device), etc... Customer can use MdiChildrenMinimizedAnchorBottom to revert for Windows default behavior.

Regression?

No

Risk

Minimal.

Screenshots

MdiChildrenMinimizedAnchor.mp4

P.s. Video above with old name of the property.

Test methodology

Manual.
Maui automated test.

Accessibility testing

Unfortunately, I do not know anything on this topic. Therefore, if this is necessary, I will need additional time to figure it out ...

Microsoft Reviewers: Open in CodeFlow

[dnfadmin]

All CLA requirements met.

[dreddy-work]

@kirsan31, Good news - API is approved with suggestions. Details are in the associated issue. Can you please update this PR and mark it ready for review?

[kirsan31]

@kirsan31, Good news - API is approved with suggestions. Details are in the associated issue. Can you please update this PR and mark it ready for review?

Excellent. I'll do it as soon as I can.

[dreddy-work]

@Tanya-Solyanik

[RussKie]

How can we test the change?

1. Please update our manual MDI sample in a way that we can toggle the property on and off and see the result.
2. We'll also need an automated test, have a look at our maui tests and add a new test project for MDI. Maybe MauiPrintPreviewDialogTests be a good start?

[RussKie]

Rebase is generally better than tracking merges

[kirsan31]

How can we test the change?

1. Please update our manual MDI sample in a way that we can toggle the property on and off and see the result.
2. We'll also need an automated test, have a look at our maui tests and add a new test project for MDI. Maybe MauiPrintPreviewDialogTests be a good start?

I will look into it...

[kirsan31]

1. Please update our manual MDI sample in a way that we can toggle the property on and off and see the result.

@RussKie designer not working with this error:

Any advice?

[RussKie]

Hmm... We don't use assembly, at least directly anywhere...
"Works on my machine" 😃 Though I'm on 17preview2

Maybe try deleting artifacts folder, then .\build.cmd, followed by .\start-vs.cmd?

[kirsan31]

Maybe try deleting artifacts folder, then .\build.cmd, followed by .\start-vs.cmd?

Not helped sadly :( So I have 2 options here:

• Uninstall 16.11 and install 17.
• Manually edit MdiChild.Designer.cs.
  ...

[RussKie]

I'm sure it worked in v16 as well.
There's a 3rd option as well - make a quick project copy these files on it, make changes, copy back.

I don't think the extent of changes that require the designer is significant.

[kirsan31]

I'm sure it worked in v16 as well.
There's a 3rd option as well - make a quick project copy these files on it, make changes, copy back.

I don't think the extent of changes that require the designer is significant.

I've already install vs17p2 and it's worked :)

Strange...

----UPD----

VS 2022 not showing any properties in designer (and no events icon at all) and constantly crashing...

Uninstalling it...

[dreddy-work]

@kirsan31 , for VS 2022 crash, was it simple scenario of opening designer from your test application? or did you perform any other actions?

[kirsan31]

@kirsan31 , for VS 2022 crash, was it simple scenario of opening designer from your test application? or did you perform any other actions?

@dreddy-work
I was able normally open src\System.Windows.Forms\tests\IntegrationTests\WinformsControlsTest\MdiChild.cs in VS2022 designer (in VS2019 it was failing with error above).
But VS2022 was not displaying control's properties. And when I was trying to see some of them (selecting different controls on the form and click properties menu), VS crashed a lot. It was crashed also when I was trying to select control in this dropdown:

[RussKie]

It may be that the latest .NET requires the newer version...

[kirsan31]

1. Please update our manual MDI sample in a way that we can toggle the property on and off and see the result.

Done:

MDICA.mp4

2. We'll also need an automated test, have a look at our maui tests and add a new test project for MDI. Maybe MauiPrintPreviewDialogTests be a good start?

Done.

[RussKie]

Almost there! 👍

[RussKie]

But VS2022 was not displaying control's properties. And when I was trying to see some of them (selecting different controls on the form and click properties menu), VS crashed a lot. It was crashed also when I was trying to select control in this dropdown:

@kirsan31 have you reported those via the VS Feedback? We're actively working through the user feedback to ensure things like that don't happen.

@merriemcgaw @JeremyKuhne FYI

[kirsan31]

@RussKie

@kirsan31 have you reported those via the VS Feedback? We're actively working through the user feedback to ensure things like that don't happen.

Sadly no, at that moment I was frantically trying to find a way to open your form in the designer to write a test :)
P.s. In the end I wrote everything manually anyway :)
P.p.s. Your suggestion

There's a 3rd option as well - make a quick project copy these files on it, make changes, copy back.

naturally worked, but after small trivial change and save it in designer, whole MdiChild.Designer.cs was totally messed up with lots of unnecessary changes :(