Repository navigation
Alpine Legs failing to build CoreCLR #4298
Description
The Alpine legs are failing due to issues building runtime's CoreCLR component. There are many errors for this component, but most of them are related to null values and null pointers. Below are two examples of errors that appeared in the build:
error: value of type 'std::nullptr_t' is not implicitly convertible to 'UINT_PTR' (aka 'unsigned long')error: cannot initialize a member subobject of type 'COUNT_T' (aka 'unsigned int') with an rvalue of type 'std::nullptr_t'
I believe that dotnet/runtime#98336 may have introduced these errors.
Link to failing build (internal Microsoft link)
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
ellahathaway commentedon Apr 5, 2024
cc @khushal1996 - pinging since I believe you originally opened the PR linked into the issue. Let me know if I should ping someone else.
BruceForstall commentedon Apr 5, 2024
@ellahathaway How did you determine that dotnet/runtime#97529 might be at fault?
This seems very likely related to dotnet/runtime#98336 -- @jkoritzinsky
ellahathaway commentedon Apr 5, 2024
Ah you're right. The commit hash pulled from the VMR build doesn't even include dotnet/runtime#97529 in the log history yet (hadn't been synced to the VMR as of that build).
I had looked through the git history of the files and saw that dotnet/runtime#98336 was merged two days ago, so I assumed that this would've gone into the VMR yesterday given that runtime syncs to sdk every day which syncs to installer every day. I've updated the issue comment to reflect the correct PR.
jkoritzinsky commentedon Apr 6, 2024
Ill take a look. I'm amazed this is only causing failures in the VMR. Don't know why that would be.
jkoritzinsky commentedon Apr 7, 2024
Looks like it's failing due to Clang 17 introducing more strict checking for nullptr->integer conversions in compile-time-constant scenarios. I was hoping to avoid having to handle this now (and instead rewriting the infrastructure that hits this) but it should be fixable without too much trouble.