Skip to content

Signing: enable NuGet signature verification by default on Linux - #31868

Merged
dtivel merged 1 commit into
mainfrom
dtivel/enable-nuget-signature-verification
Apr 20, 2023
Merged

dtivel merged 1 commit into
mainfrom
dtivel/enable-nuget-signature-verification

Conversation

@dtivel

@dtivel dtivel commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

Note: wait for NuGet's automated test results for .NET 8 SDK before merging this PR.

Resolves NuGet/Home#11262

This change enables NuGet signed package verification by default on Linux in .NET 8 SDK. Because NuGet.Client dual-inserts into both .NET 7 and 8 SDK's, NuGet needed a way to enable verification by default only in .NET 8 SDK not .NET 7 SDK. Since .NET SDK's main branch is .NET 8, this change does that by setting NuGet's environment variable DOTNET_NUGET_SIGNATURE_VERIFICATION to true in all NuGet code paths except when the variable is already set to false (because a user explicitly opted out).

The new NuGet warning NU3042 should make new failures on Linux resulting from this change actionable.

@nkolev92 informally reviewed and blessed this change before his OOF-ness.

CC @dotnet/nuget-team, @aortiz-msft, @skofman1

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Apr 18, 2023
@dtivel
dtivel force-pushed the dtivel/enable-nuget-signature-verification branch from 3dbc992 to 3aae697 Compare April 18, 2023 23:56
@dtivel
dtivel force-pushed the dtivel/enable-nuget-signature-verification branch from 3aae697 to 7494b82 Compare April 19, 2023 17:40
@dtivel
dtivel merged commit 3eafa1f into main Apr 20, 2023
@dtivel
dtivel deleted the dtivel/enable-nuget-signature-verification branch April 20, 2023 20:09
jonathanpeppers added a commit to dotnet/android that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signing: re-enable signed package verification on Linux and macOS

4 participants