Skip to content

revert part of #29916 - #29966

Merged
ViktorHofer merged 6 commits into
dotnet:mainfrom
kasperk81:patch-4
Jan 17, 2023
Merged

ViktorHofer merged 6 commits into
dotnet:mainfrom
kasperk81:patch-4

Conversation

@kasperk81

Copy link
Copy Markdown
Contributor

to unblock linux-musl test in installer dotnet/installer#15228 (comment)

@ghost

ghost commented Jan 17, 2023

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@kasperk81

Copy link
Copy Markdown
Contributor Author

@marcpopMSFT

@ViktorHofer

Copy link
Copy Markdown
Member

@kasperk81 the .NET Framework leg is failing.

@kasperk81

Copy link
Copy Markdown
Contributor Author

crossgen2.exe" exited with code -1073741819.

don't think this change can cause crossgen2 crash like that. anyways, sync'd main to rerun ci.

@kasperk81

Copy link
Copy Markdown
Contributor Author

full framework leg passed.

An update for template package 'Microsoft.TemplateEngine.Samples::8.0.100-alpha.1.23066.9' is available.

in template leg isn't related (it will be fixed once #29967 is merged)

@ViktorHofer

Copy link
Copy Markdown
Member

in template leg isn't related (it will be fixed once #29967 is merged)

Any idea why this is happening in main?

@ViktorHofer
ViktorHofer enabled auto-merge (squash) January 17, 2023 12:38
@ViktorHofer

Copy link
Copy Markdown
Member

/azp run dotnet-sdk-public-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer

Copy link
Copy Markdown
Member

Ah, we should probably add the --no-update-check Disables checking for the template package updates when instantiating a template. flag to the test invocations. Will do that in a separate PR.

@ViktorHofer

ViktorHofer commented Jan 17, 2023 •

Copy link
Copy Markdown
Member

@dotnet/templating-engine-maintainers https://github.com/dotnet/templating/blob/3b7bc2c69f41dd5205b850632b0f76c457254010/tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/VerificationEngine.cs#L340-L344 should probably pass the --no-update-check to the dotnet new <template-name> command.

A test failed here in this PR because the template samples package was installed but then later when instantiating the templates, the update checks detected a newer templates sample package being available in the feeds:

1 The template "Contoso Sample 06" was created successfully.
      + 
      + An update for template package 'Microsoft.TemplateEngine.Samples::8.0.100-alpha.1.23066.9' is available.
      + To update the package use:
      +    dotnet new install Microsoft.TemplateEngine.Samples::8.0.100-alpha.1.23067.1

Log: dotnet-new.IntegrationTests_net8.0_x64.log

@kasperk81

Copy link
Copy Markdown
Contributor Author

@ViktorHofer now there is a new pr #29969 so it is complaining about the next version

@YuliiaKovalova

Copy link
Copy Markdown
Member

I am taking a look.

@ViktorHofer
ViktorHofer merged commit eba440e into dotnet:main Jan 17, 2023
marcpopMSFT pushed a commit that referenced this pull request Jan 20, 2023
marcpopMSFT pushed a commit that referenced this pull request Jan 31, 2023
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Jan 31, 2023
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Jan 31, 2023
marcpopMSFT pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants