Skip to content

[main] Update dependencies from dotnet/runtime - #29947

Merged
tlakollo merged 5 commits into
mainfrom
darc-main-70e21190-13b6-4149-b447-e361bcf58061
Jan 16, 2023
Merged

[main] Update dependencies from dotnet/runtime#29947
tlakollo merged 5 commits into
mainfrom
darc-main-70e21190-13b6-4149-b447-e361bcf58061

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jan 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20230115.5
  • Date Produced: January 16, 2023 9:22:07 AM UTC
  • Commit: 2908445dae75580421a3585a45ba3d570bd75cd3
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
d04f600 
…0113.13

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.23062.24 -> To Version 8.0.0-alpha.1.23063.13
@ghost ghost added the Area-CodeFlow label Jan 14, 2023
@dotnet-maestro

dotnet-maestro Bot commented Jan 14, 2023

Copy link
Copy Markdown
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

dotnet-maestro Bot and others added 2 commits January 15, 2023 13:15
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
355b1a1 
…0114.6

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.23062.24 -> To Version 8.0.0-alpha.1.23064.6
Jason Zhai
Merge branch 'main' of https://github.com/dotnet/sdk into darc-main-7…
ac60e49 
…0e21190-13b6-4149-b447-e361bcf58061
@kasperk81

kasperk81 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

src/Layout/redist/redist.csproj(0,0): error NU1603: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: redist depends on Microsoft.NET.ILLink.Analyzers (>= 8.0.0-alpha.1.23064.6) but Microsoft.NET.ILLink.Analyzers 8.0.0-alpha.1.23064.6 was not found. An approximate best match of Microsoft.NET.ILLink.Analyzers 8.0.100-1.22608.1 was resolved.

@tlakollo

kasperk81
kasperk81 reviewed Jan 16, 2023
View reviewed changes
Comment thread eng/Version.Details.xml Outdated
Comment on lines +112 to +114
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="8.0.0-alpha.1.23064.6">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>968b4f8e46f78c19315cd2bd4240f47a368be11c</Sha>

@kasperk81 kasperk81 Jan 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="8.0.0-alpha.1.23064.6">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>968b4f8e46f78c19315cd2bd4240f47a368be11c</Sha>
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="8.0.100-1.23064.1">
<Uri>https://github.com/dotnet/linker</Uri>
<Sha>44520382eda0c82c5a4d3f38d3f59965f3ba90b0</Sha>

dotnet-maestro Bot and others added 2 commits January 16, 2023 13:16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
f2ee8b3 
…0115.5

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.23062.24 -> To Version 8.0.0-alpha.1.23065.5
@tlakollo
Revert illink changes from runtime
4a33228
@tlakollo
tlakollo enabled auto-merge (squash) January 16, 2023 18:44
@tlakollo
tlakollo merged commit 2f3e8b0 into main Jan 16, 2023
@tlakollo
tlakollo deleted the darc-main-70e21190-13b6-4149-b447-e361bcf58061 branch January 16, 2023 22:09
@kasperk81

kasperk81 commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

@tlakollo, is it happening because darc was switched to use linker from runtime repo which is not what we want until, at least, preview1? in that case please update the darc subscription because same thing will happen tomorrow.

@tlakollo

tlakollo commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

SDK has a runtime repo subscription meaning that all the packages produced by runtime arrive automatically to SDK. As far as I know, you cannot disable a specific package within a repo from being propagated using darc, so the change needs to be made in runtime to stop producing the package. I thought dotnet/runtime#80627 would prevent the package from being generated but apparently wasn't enough since there is a package from 1/15.
I'm working on reverting more code to stop producing the package, but this is likely going to fail tomorrow with a package from today

@tlakollo

tlakollo commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

dotnet/runtime#80720 should stop the illink package generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kasperk81 kasperk81 kasperk81 left review comments
@tlakollo tlakollo tlakollo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kasperk81 @tlakollo