[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

• Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
• Build: 20211126.4
• Date Produced: November 27, 2021 12:02:57 AM UTC
• Commit: 9ede9a29128629ffde91b16efb51c9dd6ad7d0f7
• Branch: refs/heads/main

• Updates:
  • Microsoft.NETCore.Platforms: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • Microsoft.NETCore.DotNetHostResolver: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • System.CodeDom: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • System.Security.Cryptography.ProtectedData: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • System.Resources.Extensions: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • System.Reflection.MetadataLoadContext: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • Microsoft.NET.HostModel: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • Microsoft.Extensions.DependencyModel: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • Microsoft.NETCore.App.Host.win-x64: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • Microsoft.NETCore.App.Ref: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • System.Text.Encoding.CodePages: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4
  • VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-alpha.1.21567.1 to 7.0.0-alpha.1.21576.4

[dotnet-maestro]

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

• This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
• If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
• For more details, please read the Arcade Darc documentation

[sfoslund]

@pranavkm @captainsafia we have several blazor tests failing consistently here, can you take a look?

[eerhardt]

One failure I see is:

 Test output contained the following extra linker warnings:
 ILLink : Trim analysis warning IL2045: System.ComponentModel.ReflectTypeDescriptionProvider..cctor(): Attribute 'System.Runtime.InteropServices.ComVisibleAttribute' is being referenced in code but the trimmer was instructed to remove all instances of this attribute. If the attribute instances are necessary make sure to either remove the trimmer attribute XML portion which removes the attribute instances, or override the removal by using the trimmer XML descriptor to keep the attribute type (which in turn keeps all of its instances). [C:\h\w\AD560977\t\dotnetSdkTests\e50bspja.wdr\ILLink_verify---50627DEE\AnalysisWarningsOnHelloWorldApp\AnalysisWarningsOnHelloWorldApp.csproj]

This looks like it was caused by dotnet/runtime#54056. Unfortunately I am OOF until Monday Nov 29th so I can't take a look at it until then.

@vitek-karas @sbomer @LakshanF @agocke - any chance someone on your team can take a look before then?

[vitek-karas]

The ILLink test failure is caused by this line:
https://github.com/dotnet/runtime/blob/885296a7da5f2699195df37e97e261f46d20faf2/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs#L78

The ComVisibleAttribute is now marked for removal, but it's directly references here. The reference is only used to actually ignore the attribute, so if it's removed the behavior is going to be the same. We should suppress the warning in this case.

[vitek-karas]

The ComVisibleAttribute trim failure fix is available in runtime PR dotnet/runtime#62023.

[sfoslund]

@vitek-karas it looks like dotnet/runtime#62023 was merged but we're still seeing errors, can you take a look?

[eerhardt]

There are 3 Blazor WASM tests failing with the pattern:

Running C:\h\w\A915097D\p\d\dotnet.exe msbuild /t:Publish C:\h\w\A915097D\t\dotnetSdkTests\u1dhmz0o.52z\StaticWebAsse---80EE375B\blazorwasm-minimal.csproj /restore /bl
    Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorWasmStaticWebAssetsIntegrationTest.StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets [FAIL]
      Expected subject to be a collection with 235 item(s), but found 232.

Unfortunately, the log doesn't tell us enough information about which 3 assets were missing, so this will need to be debugged locally. I'm doing it now.

[eerhardt]

I was able to debug it locally. The missing assets are:

+		[206]	Identity: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\linked\System.Security.Cryptography.Algorithms.dll, SourceType: Project, SourceId: blazorwasm, ContentRoot: ${ProjectRoot}\blazorwasm\bin\Debug\${Tfm}\publish\wwwroot\, BasePath: /, RelativePath: _framework/System.Security.Cryptography.Algorithms.dll, AssetKind: Publish, AssetMode: All, AssetRole: Primary, RelatedAsset: , AssetTraitName: BlazorWebAssemblyResource, AssetTraitValue: runtime, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: obj\Debug\${Tfm}\linked\System.Security.Cryptography.Algorithms.dll	Microsoft.AspNetCore.Razor.Tasks.StaticWebAsset
+		[207]	Identity: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\compress\[[_framework/System.Security.Cryptography.Algorithms.dll.br]], SourceType: Project, SourceId: blazorwasm, ContentRoot: ${ProjectRoot}\blazorwasm\bin\Debug\${Tfm}\publish\wwwroot\, BasePath: /, RelativePath: _framework/System.Security.Cryptography.Algorithms.dll.br, AssetKind: Publish, AssetMode: All, AssetRole: Alternative, RelatedAsset: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\linked\System.Security.Cryptography.Algorithms.dll, AssetTraitName: Content-Encoding, AssetTraitValue: br, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\linked\System.Security.Cryptography.Algorithms.dll	Microsoft.AspNetCore.Razor.Tasks.StaticWebAsset
+		[208]	Identity: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\compress\[[_framework/System.Security.Cryptography.Algorithms.dll.gz]], SourceType: Project, SourceId: blazorwasm, ContentRoot: ${ProjectRoot}\blazorwasm\bin\Debug\${Tfm}\publish\wwwroot\, BasePath: /, RelativePath: _framework/System.Security.Cryptography.Algorithms.dll.gz, AssetKind: Publish, AssetMode: All, AssetRole: Alternative, RelatedAsset: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\linked\System.Security.Cryptography.Algorithms.dll, AssetTraitName: Content-Encoding, AssetTraitValue: gzip, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: ${ProjectRoot}\blazorwasm\obj\Debug\${Tfm}\linked\System.Security.Cryptography.Algorithms.dll	Microsoft.AspNetCore.Razor.Tasks.StaticWebAsset

Looks like this may have been caused by dotnet/runtime#61543.

I'll update the base lines and push an update.

FYI - @captainsafia @pranavkm

[dougbu]

@eerhardt that didn't fix things. Errors seem fairly consistent though item counts vary.

Expected subject to be a collection with 226 item(s), but found 223.

With configuration:

Use declared types and members
Compare enums by value
Match member by name (or throw)
Be strict about the order of items in byte arrays

[eerhardt]

that didn't fix things

looks like more baselines need to be updated. I’ll do that in the morning.