Skip to content

Add library pack location - #12314

Merged
wli3 merged 5 commits into
dotnet:masterfrom
wli3:add-library-pack-location
Jul 7, 2020
Merged

wli3 merged 5 commits into
dotnet:masterfrom
wli3:add-library-pack-location

Conversation

@wli3

@wli3 wli3 commented Jul 2, 2020

Copy link
Copy Markdown

Fix #11493

Let me know if you need any unit test. I think a unit test cannot tell anything here. But I did try to drop a nupkg in the right folder and see it worked.

image

project:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net5.0</TargetFramework>
    <RestorePackagesPath>packages</RestorePackagesPath>
  </PropertyGroup>

   <ItemGroup>
    <PackageReference Include="hk2ux10wq0wlhnqpivqjfq" Version="1.0.0" />
  </ItemGroup>

</Project>

@wli3
wli3 requested review from dsplaisted, mhutch and sfoslund July 2, 2020 04:38
@wli3
wli3 force-pushed the add-library-pack-location branch from 61bbf1a to b639953 Compare July 2, 2020 16:14
William Li and others added 4 commits July 6, 2020 17:29
@wli3
wli3 merged commit 5bbf77f into dotnet:master Jul 7, 2020
@wli3
wli3 deleted the add-library-pack-location branch July 7, 2020 03:37
@dsplaisted

Copy link
Copy Markdown
Member

@wli3 It looks like the code that sets the _WorkloadLibraryPacksFolder property is no longer part of this PR. Is that intentional?

<_WorkloadLibraryPacksFolder Condition="'$(_WorkloadLibraryPacksFolder)' == ''">$([MSBuild]::EnsureTrailingSlash('$(NetCoreRoot)'))library-packs</_WorkloadLibraryPacksFolder>

@wli3

wli3 commented Jul 7, 2020

Copy link
Copy Markdown
Author

Oops good catch. A bad merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workload library pack

3 participants