Skip to content

Disable jiterp safepoints in single-threaded WASM #99558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kg merged 2 commits into from
Mar 12, 2024
Merged

Disable jiterp safepoints in single-threaded WASM #99558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d37be11
Disable jiterp safepoints in single-threaded WASM
kg Mar 11, 2024
22a3cce
Omit safepoint from cfg size calculation
kg Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/mono/browser/runtime/jiterpreter-support.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,12 +1246,14 @@ class Cfg {
this.overheadBytes += 11;
}

// Account for the size of the safepoint
if (
(branchType === CfgBranchType.SafepointConditional) ||
(branchType === CfgBranchType.SafepointUnconditional)
) {
this.overheadBytes += 17;
if (WasmEnableThreads) {
// Account for the size of the safepoint
if (
(branchType === CfgBranchType.SafepointConditional) ||
(branchType === CfgBranchType.SafepointUnconditional)
) {
this.overheadBytes += 17;
}
}
}

Expand Down Expand Up @@ -1505,6 +1507,9 @@ export const _now = (globalThis.performance && globalThis.performance.now)
let scratchBuffer: NativePointer = <any>0;

export function append_safepoint(builder: WasmBuilder, ip: MintOpcodePtr) {
// safepoints are never triggered in a single-threaded build
if (!WasmEnableThreads)
return;
// Check whether a safepoint is required
builder.ptr_const(cwraps.mono_jiterp_get_polling_required_address());
builder.appendU8(WasmOpcode.i32_load);
Expand Down