Repository navigation
[mono] Fix linux-x64 AOT-llvm perf job - #92644
Merged
Merged
Conversation
ghost
added
the 
|
Tagging subscribers to this area: @directhex Issue DetailsBased on the findings discussed in dotnet/performance#3338 Mono Linux x64 performance job wasn't doing AOT-llvm. In this PR we are adding Additionally, we are adding cc: @kotlarmilos @directhex @LoopedBard3
|
SamMonoRT
approved these changes
Sep 26, 2023
kotlarmilos
reviewed
Sep 26, 2023
cincuranet
approved these changes
Sep 26, 2023
LoopedBard3
approved these changes
Sep 26, 2023
matouskozak
marked this pull request as draft
September 27, 2023 10:06
This reverts commit fdfa9dd.
Setup x64 MonoAOT runs to be tagged as LLVM.
kotlarmilos
self-requested a review
October 3, 2023 09:43
kotlarmilos
approved these changes
Oct 3, 2023
cincuranet
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the findings discussed in dotnet/performance#3338 Mono Linux x64 performance job wasn't doing AOT-llvm. In this PR we are adding
/p:MonoAOTEnableLLVM=trueand/p:MonoEnableLLVM=truebuild flags that are needed for Ubuntu x64 to do AOT with LLVM backend.Additionally, we are adding
mono-aot-cross --llvm --versioncommand to the Helix job for future verification of enabled LLVM.Changing
llvm:falsetag tollvm:truefor x64 AOT Perf jobs. (Arm64 change will follow later for .NET 9)cc: @kotlarmilos @directhex @LoopedBard3