Skip to content

Add NuGet-Migrations workaround to runtime tests too - #84129

Merged
steveisok merged 3 commits into
dotnet:mainfrom
akoeplinger:workaround-nuget
Apr 11, 2023
Merged

steveisok merged 3 commits into
dotnet:mainfrom
akoeplinger:workaround-nuget

Conversation

@akoeplinger

Copy link
Copy Markdown
Member

See #80619

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 30, 2023
@ghost ghost assigned akoeplinger Mar 30, 2023
@steveisok

Copy link
Copy Markdown
Member

@akoeplinger it appears your change didn't apply to part of WasmBuildTests. BuildPublishTests.DefaultTemplate_WithoutWorkload failed with the NuGet-Migrations error.

@steveisok
steveisok requested review from lewing and steveisok April 3, 2023 16:20
@lewing

lewing commented Apr 11, 2023

Copy link
Copy Markdown
Member

what is the status here? tests are still failing

@jeffhandley jeffhandley added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 11, 2023
@ghost

ghost commented Apr 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

See #80619

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure-mono

Milestone: -

@steveisok

Copy link
Copy Markdown
Member

what is the status here? tests are still failing

Still trying a workaround for wbt. We could take this PR and deal with that part separately.

@steveisok
steveisok marked this pull request as ready for review April 11, 2023 22:46
@steveisok
steveisok merged commit 986bd09 into dotnet:main Apr 11, 2023
@steveisok
steveisok deleted the workaround-nuget branch April 11, 2023 22:53
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants