Repository navigation
Disallow ASG(..., IND<struct>) before morph - #74715
Merged
Merged
Conversation
ghost
added
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsRequires fixing-up some NativeAOT-specific intrinsics.
|
SingleAccretion
marked this pull request as ready for review
August 27, 2022 22:12
Contributor
Author
|
Will assume the WASM failure cannot be related. @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires fixing-up some NativeAOT-specific intrinsics.
IND<struct>after morph must still be allowed becauseFIELDnodes are morphed as such. There is also the case ofSTORE_DYN_BLK, but that will not reach local morphing code because it is a "wide" indirection.No diffs.