[mangod9]

Adding clrgc.dll (.so/dylib) to the sharedFx build so we could fallback to GC segments if required.

We dont plan to update sdk to copy things over for "Self-contained" unless it would get copied since its in the right place.

[ghost]

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Adding clrgc.dll (.so/dylib) to the sharedFx build so we could fallback to GC segments if required.

We dont plan to update sdk to copy things over for "Self-contained" unless it would get copied since its in the right place.

Author:	mangod9
Assignees:	-
Labels:	area-GC-coreclr, area-Infrastructure-installer
Milestone:	-

[mangod9]

@trylek who would be the best person to review from the infra standpoint?

[trylek]

Hmm, I'm not 100% sure, perhaps @ViktorHofer could take a first look and decide whether he feels comfortable reviewing the change or recommend someone else.

[jkoritzinsky]

I'm probably the best person to review this. It looks good to me

[mangod9]

Thanks @jkoritzinsky. Do you know what the implication of adding clrgc to Directory.Build.props is?

[jkoritzinsky]

If you add it to Directory.Build.props, then it will be in the platform manifest for all of the .sfxproj files. That means that we can ship clrgc.dll in any of the shared framework projects there and the SDK won't get confused when restoring files. The CMake change makes the file automatically shipped in any of the shared framework packages that pull CoreCLR files directly (so Microsoft.NETCore.App.Runtime, Microsoft.NETCore.App.Runtime.Composite)

I think this file will automatically be copied as part of self-contained deployment since it's in the shared-framework package, but I don't remember how the SDK pulls files for that. It won't be included in single-file deployment though, I checked how that works.

[Maoni0]

what's the criteria to include something in SCD? clrgc.dll is about 650k -

 Directory of C:\runtime-exp\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root

07/11/2022  02:45 PM           649,728 clrgc.dll

[jkoritzinsky]

I don't know the criteria, but I think we include anything that's in the runtime pack. I don't think we have an exclusion mechanism for that today.

[Maoni0]

that's great because I'd like this to be included in SCD :)

[jkoritzinsky]

Yeah if the file is listed in the framework list (which all files in a runtime pack are), it will automatically be included in the self-contained deployment. There's actually no way today to include files in the runtime pack and not include them in the framework list (we'd have to add a feature to the Shared Framework SDK in Arcade to support that)

[mangod9]

I have verified locally that clrgc.dll makes it into the Microsoft.NETCore.App.Runtime.win-x64.7.0.0-dev package. Merging now.

[mangod9]

I have verified on the latest p7 sdk that clrgc.dll is dropped with the sharedFx, and also included for --self-contained deployments.