Skip to content

Re-create profile data on profile-use-only mode - #71420

Merged
kouvel merged 1 commit into
dotnet:mainfrom
wscho77:recreate_profile_data
Jul 6, 2022
Merged

kouvel merged 1 commit into
dotnet:mainfrom
wscho77:recreate_profile_data

Conversation

@wscho77

@wscho77 wscho77 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

If a BADIMAGEFORMAT error occurs due to incorrect profile data in the multicorejit player, the profile data must be regenerated.
The profile-use-only mode, which uses only multicorejit player, must be operated the same way.

This patch activate multicorejit recorder to re-create the profile data when the multicorejit player cannot be executed due to BADIMAGEFORMAT error on profile-use-only mode.

@ghost ghost added area-TieredCompilation-coreclr community-contribution Indicates that the PR has been added by a community member labels Jun 29, 2022
@wscho77

wscho77 commented Jun 30, 2022

Copy link
Copy Markdown
Contributor Author

@kouvel Please review this patch.

In order to increase disk/flash life, I want to enable profile-only-mode.
In the profile-only-mode, it did not take the path to regenerates profile data when the profile data is incorrect.
This patch is for regenerating profile data on profiling-only-mode.

Additionally, I checked failed checker, but It doesn't seem to be related to this patch.

Activate multicorejit recorder to re-create the profile data
when the multicorejit player cannot be executed due to BADIMAGEFORMAT error on profile-use-only mode
@wscho77
wscho77 force-pushed the recreate_profile_data branch from 027d28d to 7a014fe Compare July 3, 2022 21:49
@wscho77

wscho77 commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

@jkotas Could you assign this PR to the right person for review?

@jkotas
jkotas requested a review from kouvel July 4, 2022 22:59

@kouvel kouvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kouvel
kouvel merged commit c282f06 into dotnet:main Jul 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-TieredCompilation-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants