Repository navigation
[wasm-mt] Add coop GC transitions to various EMSCRIPTEN_KEEPALIVE functions; define to noop if no threads - #69515
Merged
Merged
Conversation
lambdageek
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAny runtime function that is called from JS must perform a transition to GC unsafe mode on the multi-threaded runtime. With threading disabled, these macros will expand to nothing.
|
lambdageek
force-pushed
the
wasm-mt-timeout-gc
branch
from
May 18, 2022 21:00
e8404d7 to
8c2c79d
Compare
kg
reviewed
May 18, 2022
lambdageek
marked this pull request as ready for review
May 19, 2022 00:12
lambdageek
requested review from
SamMonoRT,
marek-safar and
vargaz
as code owners
May 19, 2022 00:12
lambdageek
force-pushed
the
wasm-mt-timeout-gc
branch
from
May 19, 2022 16:38
8c2c79d to
e1f8c64
Compare
It's called from JS
We don't need to do GC transitions if there's no threading since we won't ever suspend ourselves
lambdageek
force-pushed
the
wasm-mt-timeout-gc
branch
from
May 22, 2022 01:56
e1f8c64 to
640bffb
Compare
BrzVlad
approved these changes
May 22, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any runtime function that is called from JS must perform a transition to GC unsafe mode on the multi-threaded runtime.
With threading disabled, these macros will expand to nothing.