Skip to content

Reenable System.Runtime.Serialization.Xml.Tests - #68921

Merged
radical merged 4 commits into
dotnet:mainfrom
radical:enable-xml-ser-tests
May 10, 2022
Merged

radical merged 4 commits into
dotnet:mainfrom
radical:enable-xml-ser-tests

Conversation

@radical

@radical radical commented May 5, 2022 •

Copy link
Copy Markdown
Member

This was disabled due to #59926,
which was then tracked by #61061
.

The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one - DCS_DeeplyLinkedData.

Fixes #61061 .

This was disabled due to dotnet#59926,
which was then tracked by dotnet#61061
.

The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one - `DCS_DeeplyLinkedData`.
@radical radical added the disabled-test The test is disabled in source code against the issue label May 5, 2022
@ghost ghost assigned radical May 5, 2022
@ghost ghost added the area-Serialization label May 5, 2022
@radical
radical requested review from lewing and vargaz May 5, 2022 17:39
@radical

radical commented May 5, 2022

Copy link
Copy Markdown
Member Author

The condition on the library in tests.proj covers non-wasm cases too, but the issue that it references is closed. I will run non-wasm jobs also to confirm that this doesn't break others.

@radical

radical commented May 5, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical radical added the arch-wasm WebAssembly architecture label May 5, 2022
@ghost

ghost commented May 5, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This was disabled due to #59926,
which was then tracked by #61061
.

The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one - DCS_DeeplyLinkedData.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Serialization, disabled-test

Milestone: -

@lewing lewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is hitting the linker problem

@vargaz

vargaz commented May 5, 2022

Copy link
Copy Markdown
Contributor

SkipOnPlatform would be better imho, this is unlikely to be fixed.

@radical

radical commented May 6, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented May 9, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@radical
radical requested a review from steveisok May 9, 2022 22:38
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented May 10, 2022

Copy link
Copy Markdown
Member Author

Coreclr failure is #69101 .
Wasm failures are #69085 .
The other failures are also unrelated to this PR.

@radical
radical merged commit 21f1a2b into dotnet:main May 10, 2022
@radical
radical deleted the enable-xml-ser-tests branch May 10, 2022 04:53
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Serialization disabled-test The test is disabled in source code against the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm][aot] System.Runtime.Serialization.Xml.Tests - Maximum call stack size exceeded

5 participants