Skip to content

[wasm] Do not set _WasmDevel=true for blazor projects - #66793

Merged
adamsitnik merged 3 commits into
dotnet:mainfrom
radical:fix-wbt-oom
Mar 22, 2022
Merged

adamsitnik merged 3 commits into
dotnet:mainfrom
radical:fix-wbt-oom

Conversation

@radical

@radical radical commented Mar 17, 2022 •

Copy link
Copy Markdown
Member

to workaround wasm-ld getting oomkilled.

Fixes #66725

to workaround wasm-ld getting oomkilled.

Fixes dotnet#66725, and dotnet#66591
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Mar 17, 2022
@ghost ghost assigned radical Mar 17, 2022
@ghost

ghost commented Mar 17, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

to workaround wasm-ld getting oomkilled.

Fixes #66725, and #66591

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical
radical requested review from lewing and radekdoulik March 17, 2022 21:14
@radical
radical requested a review from akoeplinger March 21, 2022 19:20
@adamsitnik

Copy link
Copy Markdown
Member

Since this PR has 3 approvals and it fixes #66725 (which blocks clean CI and from Test Monitor perspective is the most common reason for CI failures) I am going to merge it.

@adamsitnik
adamsitnik merged commit 22f30fb into dotnet:main Mar 22, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
* [wasm] Do not set _WasmDevel=true for blazor projects

to workaround wasm-ld getting oomkilled.

Fixes dotnet#66725, and dotnet#66591

* Fix test
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WASM] BlazorWasmBuildPublishTests getting oomkill'ed during linking

5 participants